Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 17 Sep 2020 19:33:51 +0100
From:   Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To:     Lee Jones <lee.jones@linaro.org>
Cc:     knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-iio@vger.kernel.org,
        Andreas Brauchli <a.brauchli@elementarea.net>,
        Pascal Sachs <pascal.sachs@sensirion.com>
Subject: Re: [PATCH 05/30] iio: chemical: sgp30: Add description for
 sgp_read_cmd()'s 'duration_us'
Message-ID: <20200917193351.6d640cb5@archlinux>
In-Reply-To: <20200718153345.0a6a5720@archlinux>
References: <20200716135928.1456727-1-lee.jones@linaro.org>
        <20200716135928.1456727-6-lee.jones@linaro.org>
        <20200718153345.0a6a5720@archlinux>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 18 Jul 2020 15:33:45 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> On Thu, 16 Jul 2020 14:59:03 +0100
> Lee Jones <lee.jones@linaro.org> wrote:
> 
> > Fixes the following W=1 kernel build warning(s):
> > 
> >  drivers/iio/chemical/sgp30.c:236: warning: Function parameter or member 'duration_us' not described in 'sgp_read_cmd'
> > 
> > Cc: Andreas Brauchli <a.brauchli@elementarea.net>
> > Cc: Pascal Sachs <pascal.sachs@sensirion.com>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>  
> 
> Perhaps we can do better on the wording.
> 
> > ---
> >  drivers/iio/chemical/sgp30.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/iio/chemical/sgp30.c b/drivers/iio/chemical/sgp30.c
> > index 403e8803471a9..82e407d48a0aa 100644
> > --- a/drivers/iio/chemical/sgp30.c
> > +++ b/drivers/iio/chemical/sgp30.c
> > @@ -227,6 +227,7 @@ static int sgp_verify_buffer(const struct sgp_data *data,
> >   * @cmd:         SGP Command to issue
> >   * @buf:         Raw data buffer to use
> >   * @word_count:  Num words to read, excluding CRC bytes
> > + * @duration_us: Time to sleep in microseconds  
> 
> Time taken to sensor to take a reading and data to be ready.
> 
> Something like that maybe?  I've not checked the datasheet but from
> code that looks to be what this describes..

Tweaked and applied

Thanks,

Jonathan

> 
> Jonathan
> 
> >   *
> >   * Return:       0 on success, negative error otherwise.
> >   */  
>