Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp650685pxk; Thu, 17 Sep 2020 12:19:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxxaTB1i9z6UllS/fyeLY54D8/hVBJNTc4fW1FeQ/FlZN7jHWzC0Fb1DwUJCRqkIKBlY4oK X-Received: by 2002:a17:906:2552:: with SMTP id j18mr31660439ejb.476.1600370387661; Thu, 17 Sep 2020 12:19:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600370387; cv=none; d=google.com; s=arc-20160816; b=LBsp7gb1fR/r1GDxDTvkDfH4VM5YXcggIHXh1LBm8fdCWDivoTUnwKHLXJCV5KUcsm ZlQ5zUmm72QutQM8uQ8K4LaueKMqPCQX2azydxOU4W4PZpWeX87WBwcAzTJ0WoyOyuJ2 K2WBFtHjzHncvw7dDfn2jpc+EwAhkIezRWsz9/xELjqix8Fhhuf7nOia6j5n4i10ltLt EuNazx3+KdkS5Yw6ucAI3WAQ2mGH/eBl7/ynyn62BnX5I9rpAnIuJzwsMKU1ncwHACPk b8NdroOmpSKDzj7x9LpBO+GKH7IMTs3ra5+aGNc659cRp7XZfGOEz0y3wESMpV0FQPKM LXXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=XRDdNTNIua0HCbm3MCn0pcIszSG9ZVBbCO9Y6jjOxgQ=; b=0l2prGPfYyq60X3tKVbJPYWDTrQ1KRk67YfKLPmlJoid641QfWy8tngg0rkQ6IsWEj e5Mzx26TyzmU4ZYH6PRPcu5V6qFqsEyrehigI2bAuzfgP82NHQyn1fwFJySO8oha/i8G +l/JgdEr1otH6m7+nN10r5AGiBNoHY5ATEc+lVdkafpKsg2dVpjqnbV3tGy8SaPC/n9A C5c1vdrloSawzjmRkV2lw0GM0LAHhdxwMl8PgiKJLT5KIxc2eaumWPOmKojuaB5XwmCm pktSLITktLdILGOykW43yS5PnHqtys7c4cL9K/t+0Cl5r9l7yKJQYk+nXZswona8FfHm wczA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@arista.com header.s=googlenew header.b=KKG3p8Lu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=arista.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w5si597407eji.82.2020.09.17.12.19.24; Thu, 17 Sep 2020 12:19:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@arista.com header.s=googlenew header.b=KKG3p8Lu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=arista.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726390AbgIQTS0 (ORCPT + 99 others); Thu, 17 Sep 2020 15:18:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728382AbgIQQRy (ORCPT ); Thu, 17 Sep 2020 12:17:54 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0F60C061225 for ; Thu, 17 Sep 2020 09:17:46 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id q5so2830071qkc.2 for ; Thu, 17 Sep 2020 09:17:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XRDdNTNIua0HCbm3MCn0pcIszSG9ZVBbCO9Y6jjOxgQ=; b=KKG3p8LuTjIR8VB4z43UiojqXjrK+GbySfTQF4f6ZLZ2ujF/oJlKMKNsbsUaPh/Vtz 1Cj36qvj7vxhb9cM1N7/Eo+RZH/jtUiC8EQOuF0ojzm7d0SI/Ub+WpfeVohemjIxhVC3 8b4LNtSsLaSrryOqqk9pccpZIBcKyn5aEyembXRjdI1QX67WCiHaBmMaX6sdLC3EuL8D bR0zPutE+wBZ9NMnJ6Q66yuLVh2VugdKm1NFIuKMty5baRK/dFcS0boBGgxBh2AlfwUt Ia6kibbHIutM7n1eop03gvtspyFK10mTG1mnXsvzXQdCVGbd99o5BBk/1mmz71Kp1Rzr xdKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XRDdNTNIua0HCbm3MCn0pcIszSG9ZVBbCO9Y6jjOxgQ=; b=CTpLWqUGa6gRUTakQpdW1kcnMlpYZgnDSmJWqsuR9ylDADLXBZaTe8BhnwkmH5yJFD URklXgSFdx8MJ5kD5WUXMkEiaPGpzPByq0x0jgroJ/FnB9QFVEQf0eLrcPxey82Mg+Xb s8gbQEgpZSnYa7N8O0Gj1IfOY3T/QZxEzoU3B6SfE7Ro1Hf7UJIkgj5BuSpv3vbeA5d8 ofIXmt8V1igo4yLbWlqk9KdEf+IUM5qNfDa8x0nr+ZjTKiU7LdQIJvsLG/7ZS7XjExED BJjUxsJ67nZBolBKBPqtk8KM5m6xb5rk0ku6u8u5uwgnpffjyv+Y3pMIj/DG+/kdYz4Y pLcw== X-Gm-Message-State: AOAM530eeuVNHn2PJ5klcSzm2OXhiXpxdS1l6nuCVZB44RDEqWZviU3y jbE0+HFisxUvTJy1+HcWCZ4u6v5YXslWSGWrH9JJSw== X-Received: by 2002:ae9:f104:: with SMTP id k4mr18530915qkg.10.1600359464772; Thu, 17 Sep 2020 09:17:44 -0700 (PDT) MIME-Version: 1.0 References: <20200917020021.0860995C06B9@us180.sjc.aristanetworks.com> In-Reply-To: From: Francesco Ruggeri Date: Thu, 17 Sep 2020 09:17:33 -0700 Message-ID: Subject: Re: [PATCH] net: make netdev_wait_allrefs wake-able To: Eric Dumazet Cc: open list , netdev , Cong Wang , Taehee Yoo , Andrii Nakryiko , Jiri Pirko , Alexei Starovoitov , Jakub Kicinski , David Miller Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 16, 2020 at 11:51 PM Eric Dumazet wrote: > > Honestly I would not touch dev_put() at all. > > Simply change the msleep(250) to something better, with maybe > exponential backoff. OK, I will try that. Francesco