Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751846AbWHATd5 (ORCPT ); Tue, 1 Aug 2006 15:33:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751847AbWHATd5 (ORCPT ); Tue, 1 Aug 2006 15:33:57 -0400 Received: from mx2.suse.de ([195.135.220.15]:44232 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S1751846AbWHATd4 (ORCPT ); Tue, 1 Aug 2006 15:33:56 -0400 To: Herbert Xu Cc: linux-kernel@vger.kernel.org Subject: Re: [BLOCK] bh: Ensure bh fits within a page References: <20060801030443.GA2221@gondor.apana.org.au> From: Andi Kleen Date: 01 Aug 2006 21:33:54 +0200 In-Reply-To: <20060801030443.GA2221@gondor.apana.org.au> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 687 Lines: 15 Herbert Xu writes: > -- > diff --git a/fs/buffer.c b/fs/buffer.c > index 71649ef..b998f08 100644 > --- a/fs/buffer.c > +++ b/fs/buffer.c > @@ -2790,6 +2790,7 @@ int submit_bh(int rw, struct buffer_head > BUG_ON(!buffer_locked(bh)); > BUG_ON(!buffer_mapped(bh)); > BUG_ON(!bh->b_end_io); > + WARN_ON(bh_offset(bh) + bh->b_size > PAGE_SIZE); What happens when someone implements direct large page IO? -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/