Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp683020pxk; Thu, 17 Sep 2020 13:17:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy9iplFEBxHNbgP+dsKEXWXTyR9J2vrdfPOQmfJWf7IISRnqQTvQyWJ+hBB6fNhRSC4qFFf X-Received: by 2002:a17:906:c191:: with SMTP id g17mr25425585ejz.117.1600373856207; Thu, 17 Sep 2020 13:17:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600373856; cv=none; d=google.com; s=arc-20160816; b=SSP0IvlT5f0sE+UHqUcfY2p4Ics/rzT3z/aG+Zef+D4tO+bDPCqKWztJ0dYNxTYwt+ GCyTdQLQJUbvI+AsmD+ylkgPTzg2FflsDrlgT1IOUhKLsxUH3lrHRUPr/fKWNdqtVRmd 2xMwNC4QGK9ipCAfvsFFJlytfwQkv88YXWoLgD5FC9UF/m4f6FY1DJiYcHJrL4Q+xNEe 0XFGm1u6L8G8HFpVTB4AwjZpU3rRwJAZwGGRqFXzw6ZkkEou1INMhNzV4H2Z4zPgThhg DHxiUHk06WA1m0NjHAs4TRIams3ndtjPZeKv5J1X/zHxIrrPGbXb5BRib4qp4I5uzUIv kUAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=tiU1gn5XqGjxv+wdT1dHujSIM4O+HvfkFGyrVlu7OJQ=; b=q3h9xoQUV0bU+7unkxDXqMqRVG6oNsCcEXzRCYHLey9oPE2bFgqMPiFI8o42U47v02 sDaT19B/bixRULFRGUOIBdjmpmrb61XnFPd/KmRlYPwGW+v74PxC5AtjzEPY0vZp7y+N xYmYN9YJPhfdwVHGvPZK8M+pWhitio9Tn2RDIBPEpWiuoS1NiWomfIARGeTOsK2cO9UG ouJ3GUJ9EsCXTxIdETwcPpsf/iVLmmeUeY3FOONtYqJd5wzlMNfBEttg1tvMb62hNbsF 7CqK3nZ9Plz5OuDN8V4r0geg/p4CF6EUH/Lrsq4PpjKdR0YR/pFAzl709CpEXQCLcGeB tNqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="AOQA/5XF"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h16si531227edr.336.2020.09.17.13.17.12; Thu, 17 Sep 2020 13:17:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="AOQA/5XF"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726456AbgIQUNZ (ORCPT + 99 others); Thu, 17 Sep 2020 16:13:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:35462 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726301AbgIQUNY (ORCPT ); Thu, 17 Sep 2020 16:13:24 -0400 Received: from quaco.ghostprotocols.net (unknown [179.97.37.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6DDB620707; Thu, 17 Sep 2020 20:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600373603; bh=LczrSXxlFYhGfjKrHuXBmBI+IgnC0RtjmefhpAc1rls=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AOQA/5XFH0gD6CCOKU5SHStrKyleXz08tLpPB4TlJxDT0R5mv+zYsxbRzFO4qJlEN cbs4vheSyS1PoXIPTk0ADmZXPYK3IxNyCEPOeAHtATyEAKzy4Id81lHQD2RkfQoahT FrmiRnKnpwukN46U/gyLAI5BjS+vY1uk+3EukO30= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id E9F20400E9; Thu, 17 Sep 2020 17:13:20 -0300 (-03) Date: Thu, 17 Sep 2020 17:13:20 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Jin Yao , jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v6 0/7] perf: Stream comparison Message-ID: <20200917201320.GB1431236@kernel.org> References: <20200911080353.13359-1-yao.jin@linux.intel.com> <20200917130556.GA2511679@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917130556.GA2511679@krava> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Sep 17, 2020 at 03:05:56PM +0200, Jiri Olsa escreveu: > On Fri, Sep 11, 2020 at 04:03:46PM +0800, Jin Yao wrote: > > SNIP > > > main div.c:40 > > main div.c:40 > > main div.c:39 > > > > [ Hot streams in new perf data only ] > > > > hot chain 1: > > cycles: 4, hits: 4.54% > > -------------------------- > > main div.c:42 > > compute_flag div.c:28 > > > > hot chain 2: > > cycles: 5, hits: 3.51% > > -------------------------- > > main div.c:39 > > main div.c:44 > > main div.c:42 > > compute_flag div.c:28 > > > > v6: > > --- > > Rebase to perf/core > > it looks good to me > > Acked-by: Jiri Olsa Jin, I'm sorry I only got to look at this now, there are some issues, I'll try to point them out patch by patch, Thanks, - Arnaldo