Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200601091037.3794172-1-chengzhihao1@huawei.com>
 <CAFLxGvxA9pw8D6Q8GbBD0SUP+EHhOsZmRMSPxrW4sq0gYi9N9Q@mail.gmail.com> <b82cd435-437d-e384-c95e-a7e031559c7e@huawei.com>
In-Reply-To: <b82cd435-437d-e384-c95e-a7e031559c7e@huawei.com>
From:   Richard Weinberger <richard.weinberger@gmail.com>
Date:   Thu, 17 Sep 2020 22:47:46 +0200
Message-ID: <CAFLxGvxXE_jb7nGMn9XOzaFb6SELspQ2Dvdc7zs5i5G8XK3UfQ@mail.gmail.com>
Subject: Re: [PATCH 1/2] ubifs: xattr: Fix some potential memory leaks while
 iterating entries
To:     Zhihao Cheng <chengzhihao1@huawei.com>
Cc:     linux-mtd@lists.infradead.org, LKML <linux-kernel@vger.kernel.org>,
        Richard Weinberger <richard@nod.at>,
        "zhangyi (F)" <yi.zhang@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Sep 14, 2020 at 5:25 AM Zhihao Cheng <chengzhihao1@huawei.com> wrot=
e:
> =E5=9C=A8 2020/9/14 3:08, Richard Weinberger =E5=86=99=E9=81=93:
> > On Mon, Jun 1, 2020 at 11:11 AM Zhihao Cheng <chengzhihao1@huawei.com> =
wrote:
> The kill_xattrs process is more intuitive without the pxent. However,
> the release process for the memory (stores xent->name) is similar to
> 'pxent'. If you think it's better than v1, I will send v2.

You are right. We don't gain much. So I'll take v1.
Thanks a lot for fixing!

--=20
Thanks,
//richard