Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: linux-next: Tree for Sep 17 (net/ipv4/devinet.c)
To:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Nicolas Dichtel <nicolas.dichtel@6wind.com>,
        David Miller <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
References: <20200917202313.143f66f3@canb.auug.org.au>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <0b592973-55d6-b318-ed38-1d5fbd706e7a@infradead.org>
Date:   Thu, 17 Sep 2020 13:45:52 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200917202313.143f66f3@canb.auug.org.au>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 9/17/20 3:23 AM, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20200916:
> 


Maybe some older versions of gcc just can't handle IS_ENABLED() inside an
if (expression) very well.

> gcc --version
gcc (SUSE Linux) 7.5.0

This patch:

commit 9efd6a3cecdde984d67e63d17fe6af53c7c50968
Author: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date:   Wed May 13 15:58:43 2020 +0200

    netns: enable to inherit devconf from current netns

causes a build error:

../net/ipv4/devinet.c: In function ‘devinet_init_net’:
../net/ipv4/devinet.c:2672:7: error: ‘sysctl_devconf_inherit_init_net’ undeclared (first use in this function); did you mean ‘devinet_init_net’?
       sysctl_devconf_inherit_init_net == 3) {
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       devinet_init_net
../net/ipv4/devinet.c:2672:7: note: each undeclared identifier is reported only


-- 
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>