Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp711005pxk; Thu, 17 Sep 2020 14:09:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydTJpK3D4QKgU0pSMTDugFV6SDThdTde5pusSz7n6DHDqrX3raikOJPIMoPsmDYNn4DmBC X-Received: by 2002:a05:6402:1acf:: with SMTP id ba15mr33127279edb.305.1600376948924; Thu, 17 Sep 2020 14:09:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600376948; cv=none; d=google.com; s=arc-20160816; b=eXwyyZapMG07IUnN2XAnxgQvwn5fHzBD3HvjD4EZk3qyJ1rsWfWrMBnjItLYGyhDM2 76noqpiavooMgXj5k6js+CJX7QPemGX0JNK5po7Bq4Xg1+A9QJlJYa48g14K0GtHV9rh 7jCvslVzySWuuS6Bj5EJR/SImdhWGq5MCkoy4RL5lXmWw7yKUZJIWmT+ZTpIi89Y8JNJ dduZ7HXGny00xlHVp5sI9yNwr+Ah0xn7vAiaJRFQYtCP1r2HIPX3IYveMEDZEY8PoLRC SNgsKc4+Zjk3FiijZdP/MA6oUcoaTEkUusHAKVJePt+XWTjyL0NhIsbOcr0I7Mm8G+zB uSNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=ZLPIFqmOpuZBruUHp3l18k9PeqDA8K70keqtKFWuBvA=; b=tQUiY5ac6G+F99ip32lR7rgpJMUabSZf5s1ljy2yMLeKqjINCu4IJUcdGxcVCiX9P9 b6Diw8dOJ5JnJcyU/T/+e3wutfh493VAu0Arxx/eGbN+ac6WnAZO5Us8Zq8kxn3f28D+ 0L+mUcWLia3C5isfNBweLrDLM7SdiL7QVWRsgEaKYOnk7bauKwMAnJz2fIGhxJGPajGF YaZO4nFhqt6f7Y+yPhzcvlCB0cqxQrwredvjiRmI2jrjF3U3DVxmjHMNbmwOi8Xi1fh0 /blGl2Q2qAzLEexx73gmerChtlWeAFv7X8oBfgzRpoti0F0kvWjzwSDXDX+h9/ht087w E7yA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gateworks-com.20150623.gappssmtp.com header.s=20150623 header.b=qUbqArMt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j17si799263ejc.26.2020.09.17.14.08.44; Thu, 17 Sep 2020 14:09:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gateworks-com.20150623.gappssmtp.com header.s=20150623 header.b=qUbqArMt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726424AbgIQVHi (ORCPT + 99 others); Thu, 17 Sep 2020 17:07:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725900AbgIQVHi (ORCPT ); Thu, 17 Sep 2020 17:07:38 -0400 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 426B1C06174A for ; Thu, 17 Sep 2020 14:07:38 -0700 (PDT) Received: by mail-ej1-x641.google.com with SMTP id lo4so5197641ejb.8 for ; Thu, 17 Sep 2020 14:07:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZLPIFqmOpuZBruUHp3l18k9PeqDA8K70keqtKFWuBvA=; b=qUbqArMtLnslN4hZE9C58h8tbzqTr8yyZi+vRFRSg+KTFfuoi32APXnvxRVAzUq7H8 TkegtlEnpSCi39iG84+u0h8FXMj/X+DwuuuO3ZjrnyJ769DS8QvneZR+4SvathuoBvEr C29NAKj4jUJ7MuRDpZ8TKqnmdrORAVZlwVCFAHf2/EiT7Iyd6Zhox0pawAkY7oxBHlqF 6GmsnbigIWDvGw0QqJjNj3a/uc1xP44SnXqfbVs0vPVT3kdLEnEyMWBvCnK0BwERjPsa gr+Aqb87wGNRlsk1EqfO7a/LiSHXHillYs9jNNeFpiKwiBwPV0fNsDl0CWWPSeUOP+IU BZdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZLPIFqmOpuZBruUHp3l18k9PeqDA8K70keqtKFWuBvA=; b=ITCN/2DukMIuwi6WBR3SV171hgspH0dCQviRcBcemHWHaF16OnStsqq/hdj19SPyPQ nUtfi+PjRKWMW+zo3G+WGXiesp/IISdoMVwRw4X899hIA5f67Si2ZNjDTaHJ48RDS61a Mb1w+TMFqH+aAQQO9gtHhY6BX0NlTk8NWzFmAC4RtXpW71XK5Yh5DTJasivvSEsPr281 i7s+QiV9ibxZVijz45MAJg82dJFSkAkLBs8wNfSmz5T6KyOKufWxPA3VvNnfgut1922k nPCCpk+/vesOMqdJu0pgBzLCUtw8/uWbRBSn5DRP937pFjIvEnbsu8ddt41qza9G6570 KOLg== X-Gm-Message-State: AOAM533C7o9OG/VsBsB23SzL4PshCHSrWi5a+SEQCJJuDr83wYZWBqaY sYMrvBNeLi/A1hu2hFGJxX39SYEAlK40nVAy+tqkcg== X-Received: by 2002:a17:906:eb11:: with SMTP id mb17mr32020191ejb.255.1600376856595; Thu, 17 Sep 2020 14:07:36 -0700 (PDT) MIME-Version: 1.0 References: <20200917185449.5687-1-krzk@kernel.org> In-Reply-To: <20200917185449.5687-1-krzk@kernel.org> From: Tim Harvey Date: Thu, 17 Sep 2020 14:07:24 -0700 Message-ID: Subject: Re: [PATCH v2 1/4] ARM: dts: imx6qdl-gw5xxx: correct interrupt flags To: Krzysztof Kozlowski Cc: Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Adam Ford , Daniel Baluta , Anson Huang , Jacky Bai , Robin Gong , Peter Chen , Device Tree Mailing List , Linux ARM Mailing List , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 17, 2020 at 11:54 AM Krzysztof Kozlowski wrote: > > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE > 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING > > Correct the interrupt flags, assuming the author of the code wanted same > logical behavior behind the name "ACTIVE_xxx", this is: > ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW > > Signed-off-by: Krzysztof Kozlowski > > --- > > Not tested on HW. > > Changes since v1: > 1. Correct title > --- > arch/arm/boot/dts/imx6qdl-gw51xx.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw53xx.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw551x.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw552x.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw553x.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw5903.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw5904.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw5907.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw5910.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw5912.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw5913.dtsi | 3 ++- > 14 files changed, 28 insertions(+), 14 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi > index 4d01c3300b97..3c04b5a4f3cb 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -152,7 +153,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi > index f6182a9d201c..736074f1c3ef 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -217,7 +218,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi > index a28e79463d0c..8072ed47c6bb 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -210,7 +211,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi > index 55f368e192c0..8c9bcdd39830 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > #include > > / { > @@ -247,7 +248,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #address-cells = <1>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi > index 1516e2b0bcde..e5d803d023c8 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi > @@ -48,6 +48,7 @@ > #include > #include > #include > +#include > #include > > / { > @@ -219,7 +220,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw552x.dtsi b/arch/arm/boot/dts/imx6qdl-gw552x.dtsi > index 0da6e6f7482b..290a607fede9 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw552x.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw552x.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -144,7 +145,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw553x.dtsi b/arch/arm/boot/dts/imx6qdl-gw553x.dtsi > index faf9a3ba61b2..c15b9cc63bf8 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw553x.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw553x.dtsi > @@ -47,6 +47,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -180,7 +181,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi > index f68f9dada5b0..093a219a77ae 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi > @@ -47,6 +47,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -294,7 +295,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw5903.dtsi b/arch/arm/boot/dts/imx6qdl-gw5903.dtsi > index fbe6c32bd756..e1c8dd233cab 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw5903.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw5903.dtsi > @@ -47,6 +47,7 @@ > > #include > #include > +#include > > / { > chosen { > @@ -235,7 +236,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw5904.dtsi b/arch/arm/boot/dts/imx6qdl-gw5904.dtsi > index 23c6e4047621..3cd2e717c1da 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw5904.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw5904.dtsi > @@ -47,6 +47,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -257,7 +258,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw5907.dtsi b/arch/arm/boot/dts/imx6qdl-gw5907.dtsi > index b1ff7c859c4d..21c68a55bcb9 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw5907.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw5907.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -154,7 +155,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw5910.dtsi b/arch/arm/boot/dts/imx6qdl-gw5910.dtsi > index 6c943a517ad7..ed4e22259959 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw5910.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw5910.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -163,7 +164,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw5912.dtsi b/arch/arm/boot/dts/imx6qdl-gw5912.dtsi > index 441d8ce97aa4..797f160249f7 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw5912.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw5912.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -158,7 +159,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #address-cells = <1>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw5913.dtsi b/arch/arm/boot/dts/imx6qdl-gw5913.dtsi > index d62a8da49367..4cd7d290f5b2 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw5913.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw5913.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -139,7 +140,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > -- > 2.17.1 > for series: Acked-By: Tim Harvey Thanks Krzysztof Tim Tim