Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp728937pxk; Thu, 17 Sep 2020 14:46:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynpsXhcHCLAkNNQ47F1wfAd5lXiE2Ce0hGc8smVPdg1emIMJZz7qKma72/NkvwqNnWeXim X-Received: by 2002:a17:906:941a:: with SMTP id q26mr32150811ejx.496.1600379188690; Thu, 17 Sep 2020 14:46:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600379188; cv=none; d=google.com; s=arc-20160816; b=FMeGa9HTXtAxxd8V/9Bjbl3aKRfiBpsZrJ8S7NO5r2eZ9/IyAQDCQk+dwdPkm+ZS3j iOuCKL89fFWY68E9s3vIaNYSL0sVgErYorVwsPn5/FChB9kRui5VoPFgdWd10bJn/JMU vQ+JSL6TBut2NPi8P4+GmyCQu2cQKd5yGD+VTjxeKA/+Qi6vYyWbHCezD0NdFkLT6X2Q wZvdltFA30ERldE0c4oXq9/odiK9HZxw5phZuMsVBMbVyR75iRBGdn0RL6VA0ZBl/rFF ECF4v0qL8ouDwn7EZQ3HoEKV5qvALZhDC+XqTuy9p3sFznu2I+C2BTx0N3rCLvzDAd0V FOPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=yODEcUDlbHzKfZPXUKi9KjCzLNaJC6QlgxoejeeIIHo=; b=vMmQZj5m9I0zj1q6VH2BCarfdeLhVjPt/x/K2+0wcvq8ezlszSOr+QwlGqsNgEUaMe 62PanaGo6z3+8EzZf5iDhhfzCorKVv7xO5NXUSsoGqwLULBzFLEq7PYtEnDOTpgpC21U oFzm5Bk256YkTcvyhSeOFaKJhQll7wAJcY1yUGuzmyO3pGtYipNIisWTVWMIzTWmaixP jk2kdRA8rVX7MfNeXczDT9C7f8Cx97isuUxhi1Yw8jX+hG1ik3Q4kCdOWrortKLryKKp Dc/FLkrdmdMTqKP/cn3OTQO77f1Rh54hhZZQyZaCT60KdsLeVFLhvpr/9dXt+7g1B0SY mUHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e14si747437edm.126.2020.09.17.14.46.05; Thu, 17 Sep 2020 14:46:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726097AbgIQVms (ORCPT + 99 others); Thu, 17 Sep 2020 17:42:48 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:41558 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbgIQVmr (ORCPT ); Thu, 17 Sep 2020 17:42:47 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kJ1ft-00F8jM-Uo; Thu, 17 Sep 2020 23:42:41 +0200 Date: Thu, 17 Sep 2020 23:42:41 +0200 From: Andrew Lunn To: Michal Kubecek Cc: David Miller , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] ethtool: add and use message type for tunnel info reply Message-ID: <20200917214241.GC3598897@lunn.ch> References: <20200916230410.34FCE6074F@lion.mk-sys.cz> <20200917014151.GK3463198@lunn.ch> <20200917212919.3n6f3zdegjeyhfud@lion.mk-sys.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917212919.3n6f3zdegjeyhfud@lion.mk-sys.cz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On the other hand, the enums are part of userspace API so I better take > a closer look to make sure we don't run into some trouble there. Hi Michal Yes, that is what i was thinking about. But i guess you can pass a tagged enum to a function expecting an int and the compiler will silently cast it. Which is what we should have at the moment. So i'm expecting it to be O.K. Andrew