Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp746386pxk; Thu, 17 Sep 2020 15:21:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyTyBe8cEozI01YoOfyp1SyzEqJMTndA68p8b0KXtVbblE5oA7pXLSyrft6syV2QqubPuY X-Received: by 2002:aa7:cb8f:: with SMTP id r15mr36114023edt.356.1600381277158; Thu, 17 Sep 2020 15:21:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600381277; cv=none; d=google.com; s=arc-20160816; b=Db2jy7tKvtGU4BW6urkYOQq6evxMQBQtf5AnB2EUsEtBCg6XqbDsqy5fpMRyhlR29h Oa7wVJpxDSgsOm2n8UXGvb2c0hj30xIAgXONra/DwvA6N/pAei29SQ2+EUhEBQZvG+D9 4JuRYc8ZumxMg3z1o9E3CoJJnGscGlGgE1gkQERjM/JStaqxuYFOvJcAIYOp9yM7tsPj 7lmxnq7whpQavQNL9bf8xxlKG6+iaeU8A60zKS2V1jISAE31BU2Nmdu0iZGddFCbji7u PfBA0NXFvOcJvHUJKVT1etYZZ0HjLhB05l62/dfY/CbzEkXWltjXTAYa+li435jGKg7l QeNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=15AUeIGCB8Co4ppPyHutmBPEoR96J0ZC+70DS6d6lEA=; b=yc/YPbj89JbaxLO1lYRycsy/v/dC1VCNLSqxt5mZHiUpZNeMmcjVXnRZ6mRnY+QVXG lIgEH7TgkzapXzTDuElZFTq78yosdKA/uoeRhECLHLzyLWuvfHzN9+cpfu7gEnQFFdSQ ca+q8xU5vK/PeGYmPbfKosAm7ih1G+g49KUnnUqxrdDLMsQCiEu7QyQjh4C0MjtB+1r1 PrPMcJm9XYRKOpHK6PXSkWBUEHRW0IEtl525tdoutfundqMNTBJDE/KmL+FhLWrlT1Y8 wwOilV8H+dh3dRqH3E5YJyX+UWIyTvURQumAdz5pRKyctJJf4WizJfp/SY3cKcz4W67l JgWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=HbZxUoaq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z34si779319ede.447.2020.09.17.15.20.54; Thu, 17 Sep 2020 15:21:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=HbZxUoaq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726249AbgIQWRH (ORCPT + 99 others); Thu, 17 Sep 2020 18:17:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbgIQWRH (ORCPT ); Thu, 17 Sep 2020 18:17:07 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02A4EC06174A for ; Thu, 17 Sep 2020 15:17:07 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id o16so2029695pjr.2 for ; Thu, 17 Sep 2020 15:17:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=15AUeIGCB8Co4ppPyHutmBPEoR96J0ZC+70DS6d6lEA=; b=HbZxUoaquDF7xsCL0N1nGOtEhjC6k/29ufocwCgKegfzTw+SnKB4PHA5efYOqvK5H8 qB29ehLrJeRvDiCO8wPb8MQdU7Q2icOOK5ZQA/+5FaVUaFbhQF8nbM1rBfgWZ4QUsvuy i0+a0YxbWmt8uHoYV7J6SZv0i7QqbjjxftLFM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=15AUeIGCB8Co4ppPyHutmBPEoR96J0ZC+70DS6d6lEA=; b=FXiEXYYo6+8wUObAXtJaeso+6P9uMRilmkUfEhD0GMlYYe6WUCEqE7vr7coKLhDXEz PmDsBadGz2+SP/lqQa9RpZgIVpyS6OjhlUwQ6NbSvIBG/j19NpYBWNB3E1/9ZdDNp+8E xpfoTmq5750arJGx+pfkST2yGJKavYBEtKGVZn3ZTpLnC1KgkFgA09Aj87NfcRI9d1Im tXzElFVwRe8uhb8O0KthJAofM3jAz6wxRm/RaX+Hu1nPkiaCo1c2viHwTOuxhbhrE5CD TegWPC6C26M7OSVLKumh1TuyA1/urLus0nxzGoqiSY24o8nBqyk5wuMomiLV0zQZwuxI o8iA== X-Gm-Message-State: AOAM532Ppr/EhQTW/tGu/816EjhN7C+B9PjPUSmipLQQm9Gn2FIuAh5s V6BmZzlU6oPjMyFaY9ari9dujQ== X-Received: by 2002:a17:902:9343:b029:d1:f3e1:c190 with SMTP id g3-20020a1709029343b02900d1f3e1c190mr7793977plp.2.1600381026580; Thu, 17 Sep 2020 15:17:06 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h35sm626057pgl.31.2020.09.17.15.17.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 15:17:05 -0700 (PDT) Date: Thu, 17 Sep 2020 15:17:04 -0700 From: Kees Cook To: George Popescu Cc: maz@kernel.org, catalin.marinas@arm.com, will@kernel.org, masahiroy@kernel.org, michal.lkml@markovi.net, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, clang-built-linux@googlegroups.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, natechancellor@gmail.com, ndesaulniers@google.com, dbrazdil@google.com, broonie@kernel.org, maskray@google.com, ascull@google.com, akpm@linux-foundation.org, dvyukov@google.com, elver@google.com, tglx@linutronix.de, arnd@arndb.de Subject: Re: [PATCH 06/14] Fix CFLAGS for UBSAN_BOUNDS on Clang Message-ID: <202009171516.6543C7649@keescook> References: <20200914172750.852684-1-georgepope@google.com> <20200914172750.852684-7-georgepope@google.com> <202009141509.CDDC8C8@keescook> <20200915102458.GA1650630@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915102458.GA1650630@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 10:24:58AM +0000, George Popescu wrote: > This would mean losing the local-bounds coverage. I tried to test it without > local-bounds and with a locally defined array on the stack and it works fine > (the handler is called and the error reported). For me it feels like > --array-bounds and --local-bounds are triggered for the same type of > undefined_behaviours but they are handling them different. Er, if --array-bounds still works on local arrays, what does local-bounds actually do? >_> :P If we don't have a reduction in coverage, yeah, I'm fine to turn that off. -- Kees Cook