Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 17 Sep 2020 17:11:20 -0500
From:   Michael Auchter <michael.auchter@ni.com>
To:     Ben Levinsky <ben.levinsky@xilinx.com>
Cc:     punit1.agrawal@toshiba.co.jp, stefanos@xilinx.com,
        michals@xilinx.com, devicetree@vger.kernel.org,
        mathieu.poirier@linaro.org, emooring@xilinx.com,
        linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
        jliang@xilinx.com, robh+dt@kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Wendy Liang <wendy.liang@xilinx.com>,
        Michal Simek <michal.simek@xilinx.com>,
        Ed Mooring <ed.mooring@xilinx.com>, Jason Wu <j.wu@xilinx.com>
Message-ID: <20200917221120.GA15530@xaphan>
References: <20200917194341.16272-1-ben.levinsky@xilinx.com>
 <20200917194341.16272-6-ben.levinsky@xilinx.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200917194341.16272-6-ben.levinsky@xilinx.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost (2605:a601:ab6f:2000:2739:a39e:9b12:ab20) by SN4PR0601CA0021.namprd06.prod.outlook.com (2603:10b6:803:2f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.17 via Frontend Transport; Thu, 17 Sep 2020 22:11:25 +0000
X-Originating-IP: [2605:a601:ab6f:2000:2739:a39e:9b12:ab20]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9b83929c-f440-40c3-6762-08d85b569e85
X-MS-TrafficTypeDiagnostic: SN6PR04MB4751:
X-Microsoft-Antispam-PRVS: <SN6PR04MB4751ED3AECAF496D34875CEE873E0@SN6PR04MB4751.namprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: X5aqmJsOE3UJeJQJhMF1zZBMX7lxIS7ME2Pccj4X4gLUuo+En2BsFGsal39Fd9b37R3kwr6Ms7RP3Fy9kPTlPUrG+FpNH4GeEOziPF9nEGz+kO7HX4nz36pk6lOefHzACFQzAcEF6tFYJS9M7rlZM/UTdl7G032blJ2HWgMqiBhsKAAECS1i1LOsdt8q/l4wGn4qfKh1sJVo0DfZRvgkDiln031RK1zyIaFz4v6kW44gcjJehfczASYozA3m7CvPC24sFmv2n6UX0jUHo6+1qqknCrUBq6YkY4izx+HIn2s5v9IAmyX/4vJ1I8USGVUsmeKVBdeOIBXCFRLcd5EeU12KRsewE8yUVq1t1vDBJ7a5nQbGoUyM8hEGAVoZ5j8B
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN4PR0401MB3646.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(366004)(376002)(39860400002)(346002)(136003)(396003)(6916009)(4326008)(8936002)(186003)(6666004)(8676002)(16526019)(316002)(6496006)(2906002)(33656002)(66476007)(33716001)(54906003)(66556008)(7416002)(52116002)(9686003)(86362001)(66946007)(1076003)(478600001)(6486002)(44832011)(83380400001)(5660300002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: tkzn6wdRpadA2GgzGiy7z/3p3vIN3nwyidrVuNM9bEGjx061hQQJYwenhNV3sIY09+1DANdTR+rl+1m9EaHLY6sDWjhjASHv4LpyOSB5Ld8G7AOFWEm/5o139uHA2YSXb7pjJ/TGrqnRreNQocxuaC6gZKOcfJ10graxZ26UtbaFbEZw5M+QnQNuvR0pGDlg5z37KKMpwTIafMgveqIfXB6l7ex102PrkhTuSQ5e1w2PPPqQToaBugjA7iB6roAnSZ0Z5ap93lGNay/3gWAuL0jlxPlEXrfhIY10NnlX9hTZkzO0EdobWrlE/Ys1m4THMfh1BG0YhzSphya7+jKfII8/Ge9s5DKXMddloJ/EqWMLXBGa0xkWiFmXwDR4EiKKuSiZa/7UzLVE+NJz36x/GbHkPomJ+MsnxRjJ+bm5ikE719ajKh2EAYavMJbw8+EsBRbmVaR3fnSDEevyD1XRpPg+aZWgcsw86JHHqZtLJxRCXn0f/4JGs/frW+CLWtLG8+AUpqBX5QFYh4WQ1nSq7VauxdEoLKPmaubA6iedkqHJPrT34CwPeN/e/4851gzqP7YlbxY0YXJXjj6Jb2sn8gpm+Hb2cVkl1XFHGjMn4tnv0pKyOQ/Vb/5QpYZ4ECJSVRsBHApgJeGsvUk4z0LhFFF8qxPPi5QHDtF6nMA88EaB39MzN0qx3eP3u5xsnRx2MXyxqhjzy0g8CnraO4KwcQ==
X-OriginatorOrg: ni.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b83929c-f440-40c3-6762-08d85b569e85
X-MS-Exchange-CrossTenant-AuthSource: SN4PR0401MB3646.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2020 22:11:26.1071
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 87ba1f9a-44cd-43a6-b008-6fdb45a5204e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p73Bru4e7gljxqO5iZHJS9/jae0h32h1iEKX0s83Ni3mitkVec05qWvwNpQ9HxDVMuMIJMJH4uadRU167RbHDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4751
Subject: Re: [PATCH v14 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687
 definitions=2020-09-17_20:2020-09-16,2020-09-17 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_policy_notspam policy=outbound_policy score=30
 priorityscore=1501 lowpriorityscore=0 mlxscore=0 bulkscore=0 spamscore=0
 impostorscore=0 adultscore=0 malwarescore=0 suspectscore=1 clxscore=1015
 mlxlogscore=999 phishscore=0 classifier=spam adjust=30 reason=mlx
 scancount=1 engine=8.12.0-2006250000 definitions=main-2009170162
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hey Ben,

Split mode is still not functional in this patch series (as was the case
with the last few revisions).

Before sending out the next revision, can you _please_ ensure you're
testing all supported configurations?

On Thu, Sep 17, 2020 at 12:43:41PM -0700, Ben Levinsky wrote:
> +/**
> + * RPU core configuration
> + */
> +static enum rpu_oper_mode rpu_mode;
> +

<.. snip ..>

> +static int zynqmp_r5_remoteproc_probe(struct platform_device *pdev)
> +{
> +	int ret, i = 0;
> +	u32 lockstep_mode;
> +	struct device *dev = &pdev->dev;
> +	struct device_node *nc;
> +
> +	ret = of_property_read_u32(dev->of_node,
> +				   "lockstep-mode",
> +				   &lockstep_mode);
> +	if (ret < 0) {
> +		return ret;
> +	} else if (lockstep_mode != PM_RPU_MODE_LOCKSTEP &&
> +	    lockstep_mode != PM_RPU_MODE_SPLIT) {
> +		dev_err(dev,
> +			"Invalid lockstep-mode %x in %pOF\n",
> +			lockstep_mode, dev->of_node);
> +		return -EINVAL;
> +	}
> +
> +	rpu_mode = lockstep_mode;
> +
> +	dev_dbg(dev, "RPU configuration: %s\n",
> +		lockstep_mode ? "lockstep" : "split");

The binding documents lockstep-mode as:

> +  lockstep-mode:
> +    description:
> +      R5 core configuration (split is 0 or lock-step and 1)
> +    maxItems: 1

(Which needs to be reworded, but it looks like the intent was "split is
0 and lock-step is 1")

However, rpu_oper_mode is defined as:

> +enum rpu_oper_mode {
> +       PM_RPU_MODE_LOCKSTEP = 0,
> +       PM_RPU_MODE_SPLIT = 1,
> +};

so the assignment "rpu_mode = lockstep_mode" is incorrect.

- Michael