Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp753846pxk; Thu, 17 Sep 2020 15:36:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqw0R3Z1owcUXbRwXdY2ZjX5pzgYIhFbPjZeaMzB13ne2p3rO87usCO+lzEzjzEzKVHA+P X-Received: by 2002:a17:907:264c:: with SMTP id ar12mr33956996ejc.80.1600382202520; Thu, 17 Sep 2020 15:36:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600382202; cv=none; d=google.com; s=arc-20160816; b=QpGI9fvnS/silioajtQlhZ+IpF6jJ4vUCzY/7nxEQgnOA58HCgizc6qPmqMe60OEzm DUAHySjA/DRaHgVNoPWq5XbVEQMhjv8f95P7dZDVKOyV0mRF3yodGDbhpbC8eNaYuKNy kwY4A1M0SSPOAXZMlymSMDO2RKiBjA/kCOVqSd6IPZKwb6/spzSBVqwS9GHMDnLAx64l 8MSAlUa9/omB6tmUW1SACNtIcNHC2lrtkxuxQpzE2hrvDlbpzwR4c/wNj8g/BCT/uioB ujKFfi5IJtN9c19Elg4NxVGg1VFNxwNRT3CuZtmenVePnsZeqbUKxutsjlz2UijCBpb5 CmmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ptQN8m3l1yzEGb7yPqtpZCXLeExRj5wVIcUYEk876xE=; b=BkMtVMV5fBC3MnU3jC+rREYm78G4v7jwVbSuzc/v6MSy//q8n7PAoqV/cWv8dPT9Zm caTTEoNs9XshwsdSYzBxO5FuDnLDpm2O+YjOG5USAX0mICNxILYIH9Pmu3EZJX5QY01+ GCQyevpjwJfgpjy+i4kxohN+CWfB+i7PeyuazarrviMW2HaPHEUZIM0QxjMrkslbU60q gznPlsFZydbrhkSdg2XOs1dBkdNWNMWcvMwutzFSZJs6VkIOexd5DoDHH+XwdrWLCAWd ORGkmeJGy1czc2km7w4gCzy3P6953K8L/rDEiPInc5nkHpZgXo6qVbeimE5vp7rPaQ5Z ubNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nic.cz header.s=default header.b=EuhGpqLf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nic.cz Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r24si784393edc.149.2020.09.17.15.36.19; Thu, 17 Sep 2020 15:36:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nic.cz header.s=default header.b=EuhGpqLf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nic.cz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726601AbgIQWey (ORCPT + 99 others); Thu, 17 Sep 2020 18:34:54 -0400 Received: from mail.nic.cz ([217.31.204.67]:35812 "EHLO mail.nic.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726154AbgIQWeR (ORCPT ); Thu, 17 Sep 2020 18:34:17 -0400 Received: from dellmb.labs.office.nic.cz (unknown [IPv6:2001:1488:fffe:6:cac7:3539:7f1f:463]) by mail.nic.cz (Postfix) with ESMTP id 50D15142064; Fri, 18 Sep 2020 00:34:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1600382041; bh=FAMJe7ITJwHvd1FSQ0yZOsBfv9QEw/KPWeoHMgngVTg=; h=From:To:Date; b=EuhGpqLf8WvukoxqnkqlVo7N7F+M0/SnvrfyARgExn6P4fsR05N2cL92GWPjUVw4g BnD++AoZBUpMENF2CahaNhM/OP/ftITLDpqi1avAeY+foN9CIrqF9o7rVwrtsjhTxB QjpqnV2A6TbiPZ1rgdlAdxdJ37Z9YRTQQsYea/BE= From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: linux-leds@vger.kernel.org Cc: Pavel Machek , Dan Murphy , =?UTF-8?q?Ond=C5=99ej=20Jirman?= , linux-kernel@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, =?UTF-8?q?Marek=20Beh=C3=BAn?= , Simon Guinot , Simon Guinot , Vincent Donnefort , Thomas Petazzoni , Linus Walleij Subject: [PATCH leds v2 43/50] leds: ns2: cosmetic change Date: Fri, 18 Sep 2020 00:33:31 +0200 Message-Id: <20200917223338.14164-44-marek.behun@nic.cz> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200917223338.14164-1-marek.behun@nic.cz> References: <20200917223338.14164-1-marek.behun@nic.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.nic.cz X-Spam-Status: No, score=0.00 X-Spamd-Bar: / X-Virus-Scanned: clamav-milter 0.102.2 at mail X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return directly instead of setting result and breaking. Signed-off-by: Marek BehĂșn Cc: Simon Guinot Cc: Simon Guinot Cc: Vincent Donnefort Cc: Thomas Petazzoni Cc: Linus Walleij --- drivers/leds/leds-ns2.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/leds/leds-ns2.c b/drivers/leds/leds-ns2.c index dde476420a733..912db40c51183 100644 --- a/drivers/leds/leds-ns2.c +++ b/drivers/leds/leds-ns2.c @@ -65,7 +65,6 @@ struct ns2_led { static int ns2_led_get_mode(struct ns2_led *led, enum ns2_led_modes *mode) { int i; - int ret = -EINVAL; int cmd_level; int slow_level; @@ -76,12 +75,11 @@ static int ns2_led_get_mode(struct ns2_led *led, enum ns2_led_modes *mode) if (cmd_level == led->modval[i].cmd_level && slow_level == led->modval[i].slow_level) { *mode = led->modval[i].mode; - ret = 0; - break; + return 0; } } - return ret; + return -EINVAL; } static void ns2_led_set_mode(struct ns2_led *led, enum ns2_led_modes mode) -- 2.26.2