Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp771998pxk; Thu, 17 Sep 2020 16:13:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxl1SMzoQ8RsGYO0rU0BK+E1vPpjNanPBuuVXAu+pLsTwYNim574c7eAVjE0LJI5OH+V6QD X-Received: by 2002:a17:906:719a:: with SMTP id h26mr33801711ejk.336.1600384435505; Thu, 17 Sep 2020 16:13:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600384435; cv=none; d=google.com; s=arc-20160816; b=Xw0CswS94Jzdv5dyWWp4jbvjgxijHDJgsXbzdQZ5LvX3A5FgZa8084IPXDjzsvmvwv ZXux+JiGnKJhoWWAEeBcKPYTgKGpB+PVhXIS7lU/mECtje7xOfbvbmJSkIbM2INK4t47 5froaKd+Tbm5RJp13qEVuVSRNzUqCviymsmZmrsiNCH3NG32hGzpd5/Uu1h6SsmndfHS V2IrjsJW9TAZTmjeW6YM/O+8kILXqZhsS5PyleQHhbPQVtX48KcEITksPtyrHg00zIR6 nVQuASqVPqammqJXCmoYOoWKhHGDRkOyVwhBujFkFLjYaN8ZcHsszDItA/+Pr09kYFpm mh/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=BOv6VIk+zxYYNO7yKqEuqMq0K5IAwNx9wQh+JG8/Z2w=; b=YKchOwCNd3DOjbx85HAYulfbbWP6HVfHwN5/ZRmXNEADwn/AUfIWm4VXmWYgsq/4Ox yI9YdC2hzPpBJwk7Zk4WILjRnTVy0K+bnRO0DXTez+26S+G4m17M6jQulAdhqxcNXFI7 23C6GrYHz+p/vh7035AcsUGY/cGHPTcX6LGWezXcre8sLfrJZUWyBKVQrrg7SFG0a5uN OcVwxapSxa3Wj/Szid3/BjBBxfs5cRwCuAAMOFWxG/SAyOGX+tWZfT0F3mdtMfMEH9mk yMxIeX3Sq2GsYBzFET1sV7T4i7edBfh+t/pc7LA8x/cuUir9z9i/LvAfAilATY5S32mt gAbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i88si850889edd.601.2020.09.17.16.13.31; Thu, 17 Sep 2020 16:13:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726093AbgIQXM3 (ORCPT + 99 others); Thu, 17 Sep 2020 19:12:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725987AbgIQXM2 (ORCPT ); Thu, 17 Sep 2020 19:12:28 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 930DBC06174A; Thu, 17 Sep 2020 16:12:28 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id EEC6113659C88; Thu, 17 Sep 2020 15:55:38 -0700 (PDT) Date: Thu, 17 Sep 2020 16:12:04 -0700 (PDT) Message-Id: <20200917.161204.1375552873412345194.davem@davemloft.net> To: fruggeri@arista.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xiyou.wangcong@gmail.com, ap420073@gmail.com, andriin@fb.com, edumazet@google.com, jiri@mellanox.com, ast@kernel.org, kuba@kernel.org Subject: Re: [PATCH v2] net: use exponential backoff in netdev_wait_allrefs From: David Miller In-Reply-To: <20200917221922.A5D3D95C0A57@us180.sjc.aristanetworks.com> References: <20200917221922.A5D3D95C0A57@us180.sjc.aristanetworks.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Thu, 17 Sep 2020 15:55:39 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: fruggeri@arista.com (Francesco Ruggeri) Date: Thu, 17 Sep 2020 15:19:22 -0700 > static void netdev_wait_allrefs(struct net_device *dev) > { > unsigned long rebroadcast_time, warning_time; > int refcnt; > + unsigned int wait = MIN_MSLEEP; Please preserve the reverse christmas tree ordering of local variables here, thank you.