Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: XKg1Bd1Ar6jtsWnp4BRaPbHDQGu3+nPiPQh0mAypDs82pZYqWUABrn+TufnYlO7tPY7GhCXTl8
 kuBGKicq/xaQ==
IronPort-SDR: u0IPqO1dPLyUdcxT5WqP2QBoYoVgOeF0T0HWHG3n7gj0rOpfrbk7o5GkDbKxId3YE/ZWZSZqCz
 mRZ0TsoIfeTg==
From:   "Qi, Yadong" <yadong.qi@intel.com>
To:     "Christopherson, Sean J" <sean.j.christopherson@intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>
CC:     "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        "wanpengli@tencent.com" <wanpengli@tencent.com>,
        "jmattson@google.com" <jmattson@google.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>,
        "liran.alon@oracle.com" <liran.alon@oracle.com>,
        "nikita.leshchenko@oracle.com" <nikita.leshchenko@oracle.com>,
        "Gao, Chao" <chao.gao@intel.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        "Chen, Luhai" <luhai.chen@intel.com>,
        "Zhu, Bing" <bing.zhu@intel.com>,
        "Wang, Kai Z" <kai.z.wang@intel.com>
Subject: RE: [PATCH RFC] KVM: x86: emulate wait-for-SIPI and SIPI-VMExit
Thread-Topic: [PATCH RFC] KVM: x86: emulate wait-for-SIPI and SIPI-VMExit
Thread-Index: AQHWjJnLRj87Fqi/UUSARkmELHUnGqlsh5wAgABmQYCAALUAsA==
Date:   Fri, 18 Sep 2020 02:01:42 +0000
Message-ID: <MWHPR11MB1968E9F0BE3745C3D8A9FA2EE33F0@MWHPR11MB1968.namprd11.prod.outlook.com>
References: <20200917022501.369121-1-yadong.qi@intel.com>
 <c3eaf796-67f1-9224-3e16-72d93501b6cf@redhat.com>
 <20200917150217.GA13522@sjchrist-ice>
In-Reply-To: <20200917150217.GA13522@sjchrist-ice>
Accept-Language: zh-CN, en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 98d004e4-43a3-4cde-e058-08d85b76ca2d
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2020 02:01:42.6978
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 52epRsH5JmKSboZZwBfrZrkFdk79rlqVLJ5/hx1Tz6+XV+0DUq6LgWJztzE1G/3apmPt8we+CecAe2Q+5zpUHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4731
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Thu, Sep 17, 2020 at 10:56:18AM +0200, Paolo Bonzini wrote:
> > On 17/09/20 04:25, yadong.qi@intel.com wrote:
> > > From: Yadong Qi <yadong.qi@intel.com>
> > >
> > > Background: We have a lightweight HV, it needs INIT-VMExit and
> > > SIPI-VMExit to wake-up APs for guests since it do not monitoring the
> > > Local APIC. But currently virtual wait-for-SIPI(WFS) state is not
> > > supported in KVM, so when running on top of KVM, the L1 HV cannot
> > > receive the INIT-VMExit and SIPI-VMExit which cause the L2 guest
> > > cannot wake up the APs.
> > >
> > > This patch is incomplete, it emulated wait-for-SIPI state by halt
> > > the vCPU and emulated SIPI-VMExit to L1 when trapped SIPI signal
> > > from L2. I am posting it RFC to gauge whether or not upstream KVM is
> > > interested in emulating wait-for-SIPI state before investing the
> > > time to finish the full support.
> >
> > Yes, the patch makes sense and is a good addition.  What exactly is
> > missing?  (Apart from test cases in kvm-unit-tests!)
>=20
> nested_vmx_run() puts the vCPU into KVM_MP_STATE_HALTED instead of
> properly transitioning to INIT_RECEIVED, e.g. events that arrive while th=
e vCPU
> is supposed to be in WFS will be incorrectly recognized.  I suspect there=
 are other
> gotchas lurking, but that's the big one.

Thanks, Paolo and Sean.
We will continue to investigate and submit a formal patch later.

Best Regard
Yadong