Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp875192pxk; Thu, 17 Sep 2020 20:00:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzN9q1vvf+up6MAy6z5xyKba7oMMoFq3CMq2OpjhuVUjrJGDIRx5rzHivgwrFGUn0OUk7h6 X-Received: by 2002:a17:906:c411:: with SMTP id u17mr33143714ejz.319.1600398045530; Thu, 17 Sep 2020 20:00:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600398045; cv=none; d=google.com; s=arc-20160816; b=dxju7DjDN2gyMCo/r786sOvTzGwtvTNTlZjcrZsJvnoCPB/1n7ypEBzJIeclaWypOo K1bm23IEEe1gXtOk7hy1hiDOiPXutllAgHGNPSa4s/B536lA2mFyI55raRi54BFFKmcM bcMqsvOwoxppsxkB70npyGGKeKifMcABQFKfPSHemZwwidVavYE90JFi67geWAT2Qz9X t6oSfRdUkI2GUwN4v/+vK/eLA2JgIXwIvke6NqkFBRCeqoNhfVXHlLB3pyqfze0ughjp CglEI3/XhVJq/T+3U6mTI6BYOjiGyMx9qOahnlo4TDU2ni9qf9GLhPDm6mfKZZEsRFxD jxsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NsAr9oR567O3VQeKHYDg4lHOBK7fmmKFZWco3Bjgh/U=; b=pN74cqCG5Qx5F/CxH5coe9xzVxJ66l4tmzNN6UdGmKCRCtJQCvfHZ03jIas2AeNfND rQT+i3mZHiJfpTkJcsJO3jim6L6tknw3ekuXbejNKnBZVxYakoGKefZ4SmwngUWNMCxY iZKUuN1pgowb+dNNNMpuVUzJ/ipHpMykIRkYk5xpZReyhNhDj3B+gMXyxZYTo2aVGor3 7rEZipJ9TRBmDAytKDVztr0eWYFPW69vtFXePW9buoZxVmo5YEMSHPyfsH4vXmrPxx/O ARUz78rmQ8VPyA3G+LevTCOmPjRsiqqlOajdfCloJ6xErv4O/qNkZwHlfr5O2C9vKlH+ 4iPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qgOHs3rg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j20si1054798edt.233.2020.09.17.20.00.22; Thu, 17 Sep 2020 20:00:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qgOHs3rg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730394AbgIRC6W (ORCPT + 99 others); Thu, 17 Sep 2020 22:58:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:55510 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727738AbgIRCGS (ORCPT ); Thu, 17 Sep 2020 22:06:18 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B33E23772; Fri, 18 Sep 2020 02:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600394777; bh=lDDGUL4kvJ5mex8eDO//IqOW71j0i6XZXgohdWZWS0A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qgOHs3rg8KxpwAaxuyrO/XOniCXYp1V82O6SCbr4hf352OCmPVuBbiORM0Eye4lAE PkY+gmy4dBk291b7EsEJ1XGOMRU8m82mX5FaSjCQvbQdvPP8Yjmko3I7ABZEtHQnLP PEXmKiNEs1NC/Du9zheVCQ3OTzlbyrpunq5+TmNA= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Krzysztof Kozlowski , Jonathan Bakker , Mark Brown , Sasha Levin , devicetree@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 251/330] dt-bindings: sound: wm8994: Correct required supplies based on actual implementaion Date: Thu, 17 Sep 2020 21:59:51 -0400 Message-Id: <20200918020110.2063155-251-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200918020110.2063155-1-sashal@kernel.org> References: <20200918020110.2063155-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Krzysztof Kozlowski [ Upstream commit 8c149b7d75e53be47648742f40fc90d9fc6fa63a ] The required supplies in bindings were actually not matching implementation making the bindings incorrect and misleading. The Linux kernel driver requires all supplies to be present. Also for wlf,wm8994 uses just DBVDD-supply instead of DBVDDn-supply (n: <1,3>). Reported-by: Jonathan Bakker Signed-off-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20200501133534.6706-1-krzk@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- .../devicetree/bindings/sound/wm8994.txt | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/wm8994.txt b/Documentation/devicetree/bindings/sound/wm8994.txt index 68cccc4653ba3..367b58ce1bb92 100644 --- a/Documentation/devicetree/bindings/sound/wm8994.txt +++ b/Documentation/devicetree/bindings/sound/wm8994.txt @@ -14,9 +14,15 @@ Required properties: - #gpio-cells : Must be 2. The first cell is the pin number and the second cell is used to specify optional parameters (currently unused). - - AVDD2-supply, DBVDD1-supply, DBVDD2-supply, DBVDD3-supply, CPVDD-supply, - SPKVDD1-supply, SPKVDD2-supply : power supplies for the device, as covered - in Documentation/devicetree/bindings/regulator/regulator.txt + - power supplies for the device, as covered in + Documentation/devicetree/bindings/regulator/regulator.txt, depending + on compatible: + - for wlf,wm1811 and wlf,wm8958: + AVDD1-supply, AVDD2-supply, DBVDD1-supply, DBVDD2-supply, DBVDD3-supply, + DCVDD-supply, CPVDD-supply, SPKVDD1-supply, SPKVDD2-supply + - for wlf,wm8994: + AVDD1-supply, AVDD2-supply, DBVDD-supply, DCVDD-supply, CPVDD-supply, + SPKVDD1-supply, SPKVDD2-supply Optional properties: @@ -73,11 +79,11 @@ wm8994: codec@1a { lineout1-se; + AVDD1-supply = <®ulator>; AVDD2-supply = <®ulator>; CPVDD-supply = <®ulator>; - DBVDD1-supply = <®ulator>; - DBVDD2-supply = <®ulator>; - DBVDD3-supply = <®ulator>; + DBVDD-supply = <®ulator>; + DCVDD-supply = <®ulator>; SPKVDD1-supply = <®ulator>; SPKVDD2-supply = <®ulator>; }; -- 2.25.1