Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp879825pxk; Thu, 17 Sep 2020 20:10:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzOmqHSCIalr676ZfyJs57vXbYT4GPJw6Uspv4LiDsmjZ/rZdUQ1svI5B+enuHPu1VvCgOn X-Received: by 2002:a17:906:60d3:: with SMTP id f19mr35069413ejk.141.1600398617305; Thu, 17 Sep 2020 20:10:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600398617; cv=none; d=google.com; s=arc-20160816; b=isafRj5bKk9nYzeUMdkNjstH+oC3YzO3oTz83lW7+Mh52HSSpnWdKGZEy/DFJw4dui cP2VUAgxbfKbd1avX0ClLusEUI2JPQYzZdXMz795KE6NYgNca1IQMKUTahomsMzhLzot 4zgKNmgHfQuKgPH7cjVTyjBBTQsOFnuM1dv+NFqmrAdTEXXIqYEqFejcRsu1grRq2TWK TANk0x/foIlx9MRueysx0CcoUAes7ne1K1hS2CalpZb3O9e62mCZRVXXzlvm4EsxXeOw 7RF+H1YwTN2YH+1S+6E/qU7M/T4ZKRNHPZF7ziJs01aw+ny2+y92FQsXIYvBGZgpS6Kp NifQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VeOdWKmpqHyYGStzFuyO0jNaMP2IC4G3Jd04NY+8g54=; b=u9fAES/3aJj0etLgXWtpdfRtLzcEv0eSLo3fMTVdtaicEk/ChGZN+d9oOz2m3Va/WB EhASGSXYG2s07aqiQIbSrO/7EUYAtRrwCDQHRiavsFnjqM4M6Kc85wboGAgHZVk1k+x/ lAFoVs+oNQnI6z+7qP50T2ACwWcLoPomQmbRJbazP38Xty3WV0mqEcJCHFsH2bqzlFiA 6PgrrHEVvKD3YkJiOCtoSuKWsV3sDmuUvJ2DHWs58YZy5ATCB3ydO8WrF+BD359ZZdhA n7rD/QpD7dDCZq0AAiRSerYRayTGVaVZ/1salFu9zaZqR23JfFONkzUreOg8qAJvcpLZ 69qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="xDS9/NRr"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y89si1177936ede.586.2020.09.17.20.09.54; Thu, 17 Sep 2020 20:10:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="xDS9/NRr"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729601AbgIRDGk (ORCPT + 99 others); Thu, 17 Sep 2020 23:06:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:50892 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727197AbgIRCEB (ORCPT ); Thu, 17 Sep 2020 22:04:01 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5ED052388A; Fri, 18 Sep 2020 02:03:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600394638; bh=rAmBplspFq23pZd+j04CIg22Biu9ygtI+X1BwyqHbQc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xDS9/NRrKr9RamaYcMoYYf4sa4K734H1JD4yW2ygrQ/IDHsJ1prCULFnt5LfdTzpV TXyDjvxeVH8qSgNfMHzzwJgB1IoblHJ/PYFV436Kv6pLpfyPRRB/opp1mHTmvZz0qY PckV6FckO/2ae0xVPR/8lNq8qcC7yRXs5am4kPDU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Steve Longerbeam , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org, devel@driverdev.osuosl.org Subject: [PATCH AUTOSEL 5.4 137/330] media: staging/imx: Missing assignment in imx_media_capture_device_register() Date: Thu, 17 Sep 2020 21:57:57 -0400 Message-Id: <20200918020110.2063155-137-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200918020110.2063155-1-sashal@kernel.org> References: <20200918020110.2063155-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit ef0ed05dcef8a74178a8b480cce23a377b1de2b8 ] There was supposed to be a "ret = " assignment here, otherwise the error handling on the next line won't work. Fixes: 64b5a49df486 ("[media] media: imx: Add Capture Device Interface") Signed-off-by: Dan Carpenter Reviewed-by: Steve Longerbeam Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/staging/media/imx/imx-media-capture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/imx/imx-media-capture.c b/drivers/staging/media/imx/imx-media-capture.c index 46576e32581f0..d151cd6d31884 100644 --- a/drivers/staging/media/imx/imx-media-capture.c +++ b/drivers/staging/media/imx/imx-media-capture.c @@ -785,7 +785,7 @@ int imx_media_capture_device_register(struct imx_media_video_dev *vdev) /* setup default format */ fmt_src.pad = priv->src_sd_pad; fmt_src.which = V4L2_SUBDEV_FORMAT_ACTIVE; - v4l2_subdev_call(sd, pad, get_fmt, NULL, &fmt_src); + ret = v4l2_subdev_call(sd, pad, get_fmt, NULL, &fmt_src); if (ret) { v4l2_err(sd, "failed to get src_sd format\n"); goto unreg; -- 2.25.1