Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 18 Sep 2020 10:52:04 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc:     Kishon Vijay Abraham I <kishon@ti.com>,
        Rob Herring <robh+dt@kernel.org>,
        Swapnil Jakhade <sjakhade@cadence.com>,
        Yuti Amonkar <yamonkar@cadence.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        Sekhar Nori <nsekhar@ti.com>
Subject: Re: [PATCH 2/2] dt-bindings: phy: cdns,torrent-phy: add reset-names
Message-ID: <20200918052204.GD2968@vkoul-mobl>
References: <20200916124711.166643-1-tomi.valkeinen@ti.com>
 <20200916124711.166643-2-tomi.valkeinen@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200916124711.166643-2-tomi.valkeinen@ti.com>
Precedence: bulk

On 16-09-20, 15:47, Tomi Valkeinen wrote:
> Add reset-names as a required property.
> 
> There are no dts files using torrent phy yet, so it is safe to add a new
> required property.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
>  .../devicetree/bindings/phy/phy-cadence-torrent.yaml         | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> index 4071438be2ba..12ce022e4764 100644
> --- a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> +++ b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> @@ -54,6 +54,10 @@ properties:
>        Torrent PHY reset.
>        See Documentation/devicetree/bindings/reset/reset.txt
>  
> +  reset-names:
> +    items:
> +      - const: torrent_reset
> +
>  patternProperties:
>    '^phy@[0-7]+$':
>      type: object
> @@ -111,6 +115,7 @@ required:
>    - reg
>    - reg-names
>    - resets
> +  - reset-names

Update the example as well please.
>  
>  additionalProperties: false
>  
> -- 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

-- 
~Vinod