Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750949AbWHBB3A (ORCPT ); Tue, 1 Aug 2006 21:29:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750961AbWHBB3A (ORCPT ); Tue, 1 Aug 2006 21:29:00 -0400 Received: from mx1.redhat.com ([66.187.233.31]:61391 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1750949AbWHBB27 (ORCPT ); Tue, 1 Aug 2006 21:28:59 -0400 Date: Tue, 1 Aug 2006 21:28:52 -0400 From: Dave Jones To: "Antonino A. Daplas" Cc: Alan Cox , Roland Dreier , Linux Kernel , Andrew Morton Subject: Re: [PATCH] fbcon: Use persistent allocation for cursor blinking. Message-ID: <20060802012852.GD22589@redhat.com> Mail-Followup-To: Dave Jones , "Antonino A. Daplas" , Alan Cox , Roland Dreier , Linux Kernel , Andrew Morton References: <20060801185618.GS22240@redhat.com> <1154470813.15540.95.camel@localhost.localdomain> <44CFFDF1.6030909@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44CFFDF1.6030909@gmail.com> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 28 On Wed, Aug 02, 2006 at 09:20:49AM +0800, Antonino A. Daplas wrote: > >> A naiive question from someone who knows nothing about this subsystem: > >> is there any possibility of concurrent calls into this function, for > >> example if there are multiple cursors on a multiheaded system? > > > > We don't do console multihead so its basically OK. Moving all the > > console globals into a struct so we can have multiple instances would be > > a good thing [tm] and it would make sense for the variable to end up in > > said structure if it was done. > > > > Here's an update. Taking Alan's cue, I just moved the global variables > to struct fbcon_ops. Good job. Have another.. Signed-off-by: Dave Jones Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/