Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1600191369-28040-1-git-send-email-gene.chen.richtek@gmail.com>
 <1600191369-28040-3-git-send-email-gene.chen.richtek@gmail.com> <20200917184256.71328701@archlinux>
In-Reply-To: <20200917184256.71328701@archlinux>
From:   Gene Chen <gene.chen.richtek@gmail.com>
Date:   Fri, 18 Sep 2020 15:21:44 +0800
Message-ID: <CAE+NS35Pw-6UqcHPNOsUtW0GABPVEHfPineF81+qrS6A18HiyA@mail.gmail.com>
Subject: Re: [PATCH v4 2/3] Documentation: ABI: testing: mt6360: Add ADC sysfs guideline
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     Matthias Brugger <matthias.bgg@gmail.com>, knaack.h@gmx.de,
        lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Gene Chen <gene_chen@richtek.com>, Wilma.Wu@mediatek.com,
        shufan_lee@richtek.com, cy_huang@richtek.com,
        benjamin.chao@mediatek.com, Cristian Pop <cristian.pop@analog.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Jonathan Cameron <jic23@kernel.org> =E6=96=BC 2020=E5=B9=B49=E6=9C=8818=E6=
=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8A=E5=8D=881:43=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On Wed, 16 Sep 2020 01:36:08 +0800
> Gene Chen <gene.chen.richtek@gmail.com> wrote:
>
> > From: Gene Chen <gene_chen@richtek.com>
> >
> > Add ABI documentation for mt6360 ADC sysfs interfaces.
> >
> > Signed-off-by: Gene Chen <gene_chen@richtek.com>
> Would you consider using the proposed label attribute for channels?
>
> https://lore.kernel.org/linux-iio/20200916132115.81795-1-cristian.pop@ana=
log.com/T/#u
>
> I'm hoping that will remove the need to have ext name used in the majorit=
y of
> cases and would like to know if it would work for you?
> It may not work for this particular case of course.
>
> Other comments inline.
>

because of ADC layout is fixed, I can't switch channel to specific
purpose for userspace.

> > ---
> >  Documentation/ABI/testing/sysfs-bus-iio-adc-mt6360 | 83 ++++++++++++++=
++++++++
> >  1 file changed, 83 insertions(+)
> >  create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-mt6360
> >
> > diff --git a/Documentation/ABI/testing/sysfs-bus-iio-adc-mt6360 b/Docum=
entation/ABI/testing/sysfs-bus-iio-adc-mt6360
> > new file mode 100644
> > index 0000000..4b1c270
> > --- /dev/null
> > +++ b/Documentation/ABI/testing/sysfs-bus-iio-adc-mt6360
> > @@ -0,0 +1,83 @@
> > +What:                /sys/bus/iio/devices/iio:deviceX/in_voltage_USBID=
_input
>
>
> The mixture of case is a bit ugly.  Could we do
> in_voltage_usbin_input?
>

ACK

> > +KernelVersion:       5.8.0
> > +Contact:     gene_chen@richtek.com
> > +Description:
> > +             Indicated MT6360 USBID ADC which connected to connector I=
D pin.
> > +             Reading returns voltage in uV
> > +
> > +What:                /sys/bus/iio/devices/iio:deviceX/in_voltage_VBUSD=
IV5_input
>
> > +KernelVersion:       5.8.0
> > +Contact:     gene_chen@richtek.com
> > +Description:
> > +             Indicated MT6360 VBUS ADC with high accuracy
> > +             Reading returns voltage in uV
>
> Why would we ever read the low accuracy version?
>
> > +
> > +What:                /sys/bus/iio/devices/iio:deviceX/in_voltage_VBUSD=
IV2_input
> > +KernelVersion:       5.8.0
> > +Contact:     gene_chen@richtek.com
> > +Description:
> > +             Indicated MT6360 VBUS ADC with low accuracy
> > +             Reading returns voltage in uV
> > +
> > +What:                /sys/bus/iio/devices/iio:deviceX/in_voltage_VSYS_=
input
> > +KernelVersion:       5.8.0
> > +Contact:     gene_chen@richtek.com
> > +Description:
> > +             Indicated MT6360 VSYS ADC
> > +             Reading returns voltage in uV
> > +
> > +What:                /sys/bus/iio/devices/iio:deviceX/in_voltage_VBAT_=
input
> > +KernelVersion:       5.8.0
> > +Contact:     gene_chen@richtek.com
> > +Description:
> > +             Indicated MT6360 VBAT ADC
> > +             Reading returns voltage in uV
> > +
> > +What:                /sys/bus/iio/devices/iio:deviceX/in_current_IBUS_=
input
> > +KernelVersion:       5.8.0
> > +Contact:     gene_chen@richtek.com
> > +Description:
> > +             Indicated MT6360 IBUS ADC
> > +             Reading returns current in uA
> Given voltage and current are already clear from the channel type,
> could we avoid the repetition?
>
> in_current_bus_input perhaps?
>

ACK

> > +
> > +What:                /sys/bus/iio/devices/iio:deviceX/in_current_IBAT_=
input
> > +KernelVersion:       5.8.0
> > +Contact:     gene_chen@richtek.com
> > +Description:
> > +             Indicated MT6360 IBAT ADC
> > +             Reading returns current in uA
> > +
> > +What:                /sys/bus/iio/devices/iio:deviceX/in_voltage_CHG_V=
DDP_input
> > +KernelVersion:       5.8.0
> > +Contact:     gene_chen@richtek.com
> > +Description:
> > +             Indicated MT6360 CHG_VDDP ADC
> > +             Reading returns voltage in uV
> > +
> > +What:                /sys/bus/iio/devices/iio:deviceX/in_temp_TEMP_JC_=
input
> > +KernelVersion:       5.8.0
> > +Contact:     gene_chen@richtek.com
> > +Description:
> > +             Indicated MT6360 IC junction temperature
> > +             Reading returns temperature in degree
> > +
> > +What:                /sys/bus/iio/devices/iio:deviceX/in_voltage_VREF_=
TS_input
> > +KernelVersion:       5.8.0
> > +Contact:     gene_chen@richtek.com
> > +Description:
> > +             Indicated MT6360 VREF_TS ADC
> > +             Reading returns voltage in uV
> > +
> > +What:                /sys/bus/iio/devices/iio:deviceX/in_voltage_TS_in=
put
> > +KernelVersion:       5.8.0
> > +Contact:     gene_chen@richtek.com
> > +Description:
> > +             Indicated MT6360 TS ADC
> > +             Reading returns voltage in uV
> > +
> > +What:                /sys/bus/iio/devices/iio:deviceX/timestamp
> > +KernelVersion:       5.8.0
> > +Contact:     gene_chen@richtek.com
> > +Description:
> > +             Indicated MT6360 timestamp
> > +             Reading returns current timestamp in ms
>
> That's an odd bit of ABI.  Why would we want to read the current timestam=
p from
> sysfs?  Timestamps in IIO also tend to be in nano seconds.
>
>
>
>

ACK, I will remove this.