Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751093AbWHBDKi (ORCPT ); Tue, 1 Aug 2006 23:10:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751096AbWHBDKi (ORCPT ); Tue, 1 Aug 2006 23:10:38 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38793 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S1751093AbWHBDKh (ORCPT ); Tue, 1 Aug 2006 23:10:37 -0400 From: Andi Kleen To: "Eric W. Biederman" Subject: Re: [PATCH 9/33] i386 boot: Add serial output support to the decompressor Date: Wed, 2 Aug 2006 05:10:07 +0200 User-Agent: KMail/1.9.3 Cc: linux-kernel@vger.kernel.org, Horms , Jan Kratochvil , "H. Peter Anvin" , Magnus Damm , Vivek Goyal , Linda Wang References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200608020510.07569.ak@suse.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 22 > > /* WARNING!! > > * This code is compiled with -fPIC and it is relocated dynamically > > * at run time, but no relocation processing is performed. > > * This means that it is not safe to place pointers in static structures. > > */ iirc the only static relocation in early_printk is the one to initialize the console pointers - that could certainly be moved to be at run time. > lib/string.c might be useful. The fact that the functions are not > static slightly concerns me. I have a vague memory of non-static > functions generating relocations for no good reason. Would surprise me. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/