Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1070927pxk; Fri, 18 Sep 2020 03:07:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyl4WkZJtB7riXaLRB4ca81O0wW2ftLU+1YjCKboFCgNxOGiyNhxW8v/w2FJF49pcH/cV2W X-Received: by 2002:a50:dec9:: with SMTP id d9mr37870465edl.145.1600423622529; Fri, 18 Sep 2020 03:07:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600423622; cv=none; d=google.com; s=arc-20160816; b=aiwGy4u+NWGUbOQ9H49FBPyZtuqQhr9LbsDjJ5PGfkTCxk6WNdMZ3bpOrEBiMAuXQr YHC20DCVDuUQgLWtnkQQzzSOshRCy/GK3xRyClpO0SDyeJj15Fyblb9ZpEgO0E0sFrVa y53XgPv6umE59h3iOrXNfVHpGg7TrgOx2Wye1rMvPZCIPXKTKODcrVx1A+uqguNoK5hi TnLEuDuyloedVSLZwo/eCEzVpbAPBHeKmvnuRzcRDXYOhbgGhXnpQso4Nnj3GraMRZp+ VtKAn0pNOwiiU2iO07mtTraREjygpI0UWLuKcrrPUzJpA3016MsXdLNBgm69d2rlBQdU Xffg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=FGQLjZlO3EeAAg5Wdz5a+Q7zaxpTYWBc2vHtkKa03bU=; b=IgOX0Jazd1C0WSU9B6EEnmXIUMSwm+9o+43QfvTrxaVqvRlhhfcp1ygCM/lg4txWU+ AQUoeRHWKuTUMICUXknPABj0rmrtv20//Z3RaktrAvNiZNkFcsrk2H013NDDpSx7eGio gtGMBOwpYvhvFL920JexicYctErvoZ7xTrFhCyGUyz4SXGMZHqvyAP7aViOqKZZ3bPtm R0NLt7KSdlnzhhbXQ+5mN+cP2lDBesl5u90zH/REZc3yl6s4+1/Kn6dLMXojkH6bbEcv RMtEH08f8zqtiUbnj2uzHUPpG6wsfL4Pwe87Ngw0LetsQim/r4SRjwuYBtAknj2ek4+b WTsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bHddCIFC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v21si2071511ejg.582.2020.09.18.03.06.39; Fri, 18 Sep 2020 03:07:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bHddCIFC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726427AbgIRKFc (ORCPT + 99 others); Fri, 18 Sep 2020 06:05:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:50712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725874AbgIRKFb (ORCPT ); Fri, 18 Sep 2020 06:05:31 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C487520665; Fri, 18 Sep 2020 10:05:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600423531; bh=h0lkuxqUPtrrUnI9EjvXQhkOT9wfxsfGvLGrRfcRWpw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bHddCIFCZn4+sdX5R0OHIYUPadPzF8mhaCWTel5RLNX1E0Row0SILO/lOvsav2PCO 8lc0l0iFGenegjZeJyefH34rt6vrt7hwHMimIz1+tXzsggxE6OsLuf4nfV+aRo639+ Tb4MRuZx6/tMbSOv9EQ7X/TY2wR3ZrF3p02ZI6Js= Date: Fri, 18 Sep 2020 11:04:40 +0100 From: Mark Brown To: Guenter Roeck Cc: Alban Bedel , linux-hwmon@vger.kernel.org, Jean Delvare , Rob Herring , Liam Girdwood , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] hwmon: (lm75) Add regulator support Message-ID: <20200918100440.GB5703@sirena.org.uk> References: <20200917101819.32045-1-alban.bedel@aerq.com> <20200917101819.32045-4-alban.bedel@aerq.com> <7986c014-b826-bad1-f19c-cdda31d20804@roeck-us.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0eh6TmSyL6TZE2Uz" Content-Disposition: inline In-Reply-To: <7986c014-b826-bad1-f19c-cdda31d20804@roeck-us.net> X-Cookie: Beware of geeks bearing graft. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --0eh6TmSyL6TZE2Uz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 17, 2020 at 10:33:37PM -0700, Guenter Roeck wrote: > On 9/17/20 3:18 AM, Alban Bedel wrote: > > + err = regulator_enable(data->vs); > How about device removal ? Don't you have to call regulator_disable() > there as well ? If so, it might be best to use devm_add_action_or_reset() > to register a disable function. Yes, disables should be balanced (and any attempt to unregister the regulator with references still held should result in a warning). --0eh6TmSyL6TZE2Uz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9khjgACgkQJNaLcl1U h9AdDAf/YNuWEsjoIefRmZlEaEFDrFOFf++WJDvAcSCC0fP0VeoLuRhuNjHGdYDM jmwCuCSjeb0sX74vrLNmK6/SIsny3ffxorGP+OVo2mluxO8VRnLQT/DkgXiZ6eAH 1Tk7/v3jzHDyeRNvXEnGmGTq4BqmSa7LgOozSOJkVWuJvfPDJQyipK4/bYF+taN0 c5I8179rpeBwQXFfT5SywLx1G2MIxg7TfgmBqdftTnc7+dLlJ94iN7twLoprtYt4 ujfCjaEM2+Bq3EZgIFBzIWW+j2x79l95Tm0JGPqVog4c72At13ZjgWdvBQknHzIT H7hOtmKbybGcenxIEVbo/ebAD8H/3A== =n9tP -----END PGP SIGNATURE----- --0eh6TmSyL6TZE2Uz--