Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 18 Sep 2020 12:07:43 +0200
From:   peterz@infradead.org
To:     Jan Kara <jack@suse.cz>
Cc:     Oleg Nesterov <oleg@redhat.com>, Boaz Harrosh <boaz@plexistor.com>,
        Hou Tao <houtao1@huawei.com>, Ingo Molnar <mingo@redhat.com>,
        Will Deacon <will@kernel.org>, Dennis Zhou <dennis@kernel.org>,
        Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC PATCH] locking/percpu-rwsem: use this_cpu_{inc|dec}() for
 read_count
Message-ID: <20200918100743.GK35926@hirez.programming.kicks-ass.net>
References: <20200915150610.GC2674@hirez.programming.kicks-ass.net>
 <20200915153113.GA6881@redhat.com>
 <20200915155150.GD2674@hirez.programming.kicks-ass.net>
 <20200915160344.GH35926@hirez.programming.kicks-ass.net>
 <b885ce8e-4b0b-8321-c2cc-ee8f42de52d4@huawei.com>
 <ddd5d732-06da-f8f2-ba4a-686c58297e47@plexistor.com>
 <20200917120132.GA5602@redhat.com>
 <20200918090702.GB18920@quack2.suse.cz>
 <20200918100112.GN1362448@hirez.programming.kicks-ass.net>
 <20200918100432.GJ35926@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200918100432.GJ35926@hirez.programming.kicks-ass.net>
Precedence: bulk

On Fri, Sep 18, 2020 at 12:04:32PM +0200, peterz@infradead.org wrote:
> On Fri, Sep 18, 2020 at 12:01:12PM +0200, peterz@infradead.org wrote:
> > @@ -198,7 +198,9 @@ EXPORT_SYMBOL_GPL(__percpu_down_read);
> >   */
> >  static bool readers_active_check(struct percpu_rw_semaphore *sem)
> >  {
> > -	if (per_cpu_sum(*sem->read_count) != 0)
> > +	u64 sum = per_cpu_sum(*(u64 *)sem->read_count);
> > +
> > +	if (sum + (sum >> 32))
> 
> That obviously wants to be:
> 
> 	if ((u32)(sum + (sum >> 32)))
> 
> >  		return false;
> >  
> >  	/*

I suppose an alternative way of writing that would be something like:

	union {
		u64 sum;
		struct {
			u32 a, b;
		};
	} var;

	var.sum = per_cpu_sum(*(u64 *)sem->read_count);

	if (var.a + var.b)
		return false;

which is more verbose, but perhaps easier to read.