Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1081808pxk; Fri, 18 Sep 2020 03:21:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/9+r6zsMh51NqdXAhzzA5gU9TqkXVzRkeCIixQOS4uyZeQys0yqNWt7gfv1PZaCjrtSCU X-Received: by 2002:a50:f199:: with SMTP id x25mr36677288edl.347.1600424497060; Fri, 18 Sep 2020 03:21:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600424497; cv=none; d=google.com; s=arc-20160816; b=On9TR/SpM4Gb33ef16PQwbvslhI0LIgpQaZLmc7lr2PLxXDFHUyzjHL3Ubq5JdarNr cZFy9IvJ6lgamSdXJQlyZ2tSIv9HIxHbIzvk8GEnmC0KUitgbBYV+x3QTLHCi3rpTyG6 aaOntCATPF6vuwrW9W0JsnmcwSxfMUr+Qm0Jb5appU4Ze4AAQxwTbMeqlg2vFsrH2NYp 4BgmZvKdS/sfY6Pi55E0/PB6CTn3NdmuXk1hSLx2wSW2MxWjcQ0tlGfv5tx/sNI5Xn+H ij+wA9+qADCd8z8MDZRy0dYuAYCtANoLK0W1tmb2Ss/ulSVlJA0ZcWqdGtvJQS+Mf4UA kw3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=+1tfKTsp01ZqfsO1Bgw1xbBGbg1bO7ELM404DFxXUqU=; b=giB0PoQ9Q4iYMXPY11tFd9oK0VnZBISI/tOuWKYWu43aexlT8rTvUhlTxMY52jYXYQ jKLZKhlbo4FIRwIYrvCFFtvZZkFUg4e1zK/M40sdVl9v6/7bgl94gm4+te33lflr+HkT TLjbQIkLsR23IGCvdjExyDjCKGgNFiZFoq+lkMCUsW8GKTbfiCbNdVk/aYy07he8SjQA 84+9wenqOsg/Ri23IJuj4G6Q0AEyusMO4oUtWpIlDyaOt4LAA5/N/lAFbIu1TGWk8BcY MUwGkm5rQWEPWPICdNAh1FFNEBuKiNx20x+T5mGmxLpKlr3A79yQ83w5zL1VWmpM9ZqN /xDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v5si1830259edr.49.2020.09.18.03.21.14; Fri, 18 Sep 2020 03:21:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726759AbgIRKSX (ORCPT + 99 others); Fri, 18 Sep 2020 06:18:23 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:56636 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726365AbgIRKSW (ORCPT ); Fri, 18 Sep 2020 06:18:22 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 221EBF2213E9275D43B8; Fri, 18 Sep 2020 18:18:20 +0800 (CST) Received: from huawei.com (10.90.53.225) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Fri, 18 Sep 2020 18:18:12 +0800 From: Zheng Bin To: , , , , , , CC: , Subject: [PATCH -next 3/9] rtlwifi: rtl8192cu: fix comparison to bool warning in mac.c Date: Fri, 18 Sep 2020 18:24:59 +0800 Message-ID: <20200918102505.16036-4-zhengbin13@huawei.com> X-Mailer: git-send-email 2.26.0.106.g9fadedd In-Reply-To: <20200918102505.16036-1-zhengbin13@huawei.com> References: <20200918102505.16036-1-zhengbin13@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.90.53.225] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:161:14-17: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:168:13-16: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:179:14-17: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:186:13-16: WARNING: Comparison to bool Signed-off-by: Zheng Bin --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c index d7afb6a186df..2890a495a23e 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c @@ -158,14 +158,14 @@ bool rtl92c_init_llt_table(struct ieee80211_hw *hw, u32 boundary) for (i = 0; i < (boundary - 1); i++) { rst = rtl92c_llt_write(hw, i , i + 1); - if (true != rst) { + if (!rst) { pr_err("===> %s #1 fail\n", __func__); return rst; } } /* end of list */ rst = rtl92c_llt_write(hw, (boundary - 1), 0xFF); - if (true != rst) { + if (!rst) { pr_err("===> %s #2 fail\n", __func__); return rst; } @@ -176,14 +176,14 @@ bool rtl92c_init_llt_table(struct ieee80211_hw *hw, u32 boundary) */ for (i = boundary; i < LLT_LAST_ENTRY_OF_TX_PKT_BUFFER; i++) { rst = rtl92c_llt_write(hw, i, (i + 1)); - if (true != rst) { + if (!rst) { pr_err("===> %s #3 fail\n", __func__); return rst; } } /* Let last entry point to the start entry of ring buffer */ rst = rtl92c_llt_write(hw, LLT_LAST_ENTRY_OF_TX_PKT_BUFFER, boundary); - if (true != rst) { + if (!rst) { pr_err("===> %s #4 fail\n", __func__); return rst; } -- 2.26.0.106.g9fadedd