Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1131825pxk; Fri, 18 Sep 2020 04:46:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5u68eA8tS5+8CFlSnpC5MFrxaHBfeWoH+5P8LWTSuzNyA1MBMXEhL+Qzn8NuTE3VCeY3H X-Received: by 2002:a17:906:15c4:: with SMTP id l4mr34824768ejd.78.1600429614067; Fri, 18 Sep 2020 04:46:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600429614; cv=none; d=google.com; s=arc-20160816; b=YsXJ0Zl8Jw/9rTpF2KrpQoxE6bx5JGkgItS8Y+OW6Ep5XsGhAZtrWIINvyb/FTBCZE MwJjzdAexG75K2RDTX5/RZuSWK5pQOSC0YR8yJ6NbhjkVkbvkxSgiTG+CGZL2Xi5Ylmp 6u0VJa26/kXt+wZ2Sdhzv8ekdI7qqjkzSNPFjk1r7+fKEKwIIKR09PJR7t1EVZDomQvx OqX/ztD4Kpe3WkU4Z11XxhqrsQsOimrlZKcQf0NSKBTeTT+pZ4NxeqIUS7JZXJiV8OTA XgrMfTnpeHM0FAFD6mhlmLmUxsITctqqUcCvT00QnnAyAxCv5qS7Znzhf35dW5Q/43W1 BGiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=1sRMVJlWqhwC/2swraPv+lsWbWwxNCSMocd/JVpfnjw=; b=F4/PnoqyebMuB3XCPlT6ykgeuSEOLwvLXFLmgYxHLjavbzjLAIe2S+OBdQVLmuI/x/ Qkk0bO0uY6bxstoPqlN9e4P0smEQEeNWuepjwiGTlrJV16fs5I2UxdcWKjyQ6wGIIkj3 49r0xSA6saC6bD7aGd4uo6pgGsXLNU7ZLWxEPAZealRPcIIH4P12Q7D3oyoCuK6e547y POLFY7HG+lk/xrZBptG50ZOJ7smWVt0uORTaaCov6fN1nV/HXhrcjed+fFesVqs3Mku+ KKbxk6wqsZmB5ALC+pfAkFzKH5JVRFbIjQcN20+zS3EkBevZzU3M68r8FJdZ/1COhRMK /F+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d26si1850784edx.497.2020.09.18.04.46.31; Fri, 18 Sep 2020 04:46:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726473AbgIRLpQ (ORCPT + 99 others); Fri, 18 Sep 2020 07:45:16 -0400 Received: from foss.arm.com ([217.140.110.172]:40078 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726115AbgIRLpP (ORCPT ); Fri, 18 Sep 2020 07:45:15 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C5B7B11D4; Fri, 18 Sep 2020 04:45:14 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5B2F13F73B; Fri, 18 Sep 2020 04:45:13 -0700 (PDT) Date: Fri, 18 Sep 2020 12:45:08 +0100 From: Lorenzo Pieralisi To: linux-kernel@vger.kernel.org, Arnd Bergmann , "David S. Miller" , bhelgaas@google.com Cc: Catalin Marinas , Will Deacon , George Cherian , Yang Yingliang , linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 0/3] Fix pci_iounmap() on !CONFIG_GENERIC_IOMAP Message-ID: <20200918114508.GA20110@e121166-lin.cambridge.arm.com> References: <20200915093203.16934-1-lorenzo.pieralisi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 16, 2020 at 12:06:55PM +0100, Lorenzo Pieralisi wrote: > v2 of a previous posting. > > v1->v2: > - Added additional patch to remove sparc32 useless __KERNEL__ > guard > > v1: https://lore.kernel.org/lkml/20200915093203.16934-1-lorenzo.pieralisi@arm.com > > Original cover letter > --- > > Fix the empty pci_iounmap() implementation that is causing memory leaks on > !CONFIG_GENERIC_IOMAP configs relying on asm-generic/io.h. > > A small tweak is required on sparc32 to pull in some declarations, > hopefully nothing problematic, subject to changes as requested. > > Previous tentatives: > https://lore.kernel.org/lkml/20200905024811.74701-1-yangyingliang@huawei.com > https://lore.kernel.org/lkml/20200824132046.3114383-1-george.cherian@marvell.com > > Cc: Bjorn Helgaas > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Arnd Bergmann > Cc: "David S. Miller" > Cc: George Cherian > Cc: Yang Yingliang > > Lorenzo Pieralisi (3): > sparc32: Remove useless io_32.h __KERNEL__ preprocessor guard > sparc32: Move ioremap/iounmap declaration before asm-generic/io.h > include > asm-generic/io.h: Fix !CONFIG_GENERIC_IOMAP pci_iounmap() > implementation > > arch/sparc/include/asm/io_32.h | 17 ++++++--------- > include/asm-generic/io.h | 39 +++++++++++++++++++++++----------- > 2 files changed, 34 insertions(+), 22 deletions(-) Arnd, David, Bjorn, I have got review/test tags, is it OK if we merge this series please ? Can we pull it in the PCI tree or you want it to go via a different route upstream ? Please let me know. Thanks, Lorenzo