Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1219609pxk; Fri, 18 Sep 2020 07:02:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwDZZp4qoou+dPPxV8MCW0G0K0vryI1YrHOazY4qaJ8kIPyNSc6Vs7PYQJV6o7a0R6AIpos X-Received: by 2002:a05:6402:a51:: with SMTP id bt17mr25958286edb.186.1600437758719; Fri, 18 Sep 2020 07:02:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600437758; cv=none; d=google.com; s=arc-20160816; b=hAlAhF9ohHUULDysyfRYMqinQ1vtE+r/olR+TCR5t4RYzX7MdvFtqtGuDMrVt2GT4x qFXgeAnEBBDeoF+/c7ZzFx1RfDUbAM9EiOdjaESmqmszaz46SDmv4bAI6+UFyaWGgCJD GrSgZQsPo9HPJUqzALSeMNmD/Qhld618lQokpvQceW+iF5NJndcstIGqXhh+MUp+6l67 dMBcC1CMNyC25ypu4n93bdWt3uNeUKHdxg9jHdP3fOfQMYKq+mYOC980LEDmEXYUV+NQ lh/2kgOHc1BrYxb3YxWHxA7l9TmDeuhYU1eEmcTfT+4nsijogbFNficYKDBX7kSvBZEY lBHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=R6MdPkjl7MQc9cg91KiiB5KfM8M+NWHuJo4hFIyFjPo=; b=UzAf2MKzsUBwVMOg7gJiPEMiYan21sWbxLRSkwTRjBwqNExtA421Fyek975iy3nvPy CjygceEtnO/Z7SsNRFF+rYixM4w2dRVEfZhZSebdZzDHp+FDQHqa1+niGWQQYkISbYuZ /JemL9W5454SMSH56ekL6DJJIPFzUiuDFSKKXwRVWLke2EAI+dQqVx3Fj/YmCkeON5su PVYukjP1nJjHnEysV/Ev+SqcL6yfbHC9Jm76gkyjlMvNnAmnDz6r4HuKy+guodUn93FK Fg4qYboMsDE3JytvB7GIrt8HMtQ/a59ny5rPp0z2aNXWS3awMYnzSUXOk+hon0Vn0qFr JsTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="U/35TaPt"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gu16si2261865ejb.218.2020.09.18.07.02.13; Fri, 18 Sep 2020 07:02:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="U/35TaPt"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726526AbgIROBP (ORCPT + 99 others); Fri, 18 Sep 2020 10:01:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726129AbgIROBP (ORCPT ); Fri, 18 Sep 2020 10:01:15 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C07BC0613CE; Fri, 18 Sep 2020 07:01:15 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id w7so3501680pfi.4; Fri, 18 Sep 2020 07:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R6MdPkjl7MQc9cg91KiiB5KfM8M+NWHuJo4hFIyFjPo=; b=U/35TaPtjgB5r/mYNH/5TF4YEtf+aIq0VgrsclABnXH2l4sdR3wr1X4iJKmOEaZFwc yyPgo1XgVs9HXuIcwhAzMa3fFt0CqX3RQVU5LtFnP/IBdR5NEOgxbTShZWivHfn426PY 0YjrxrRjjULwCy8zLkODLDX4LCgZUOeO8CCkeRNyJdMn3oDALTsdNMA048xGoaPAGIog D13ql8vSZETeGqhGK8A7x/i4CYggSqAeMOGfr8KaMz76bupXvMALX7eJYcrIyrTW7tcF 3ekvTDbTf7mA8qsq0AjYYpJkG2YMTC03zB2QHc7Gadvyp9jo2BW7DzFMFx09AG3dddbs uVTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R6MdPkjl7MQc9cg91KiiB5KfM8M+NWHuJo4hFIyFjPo=; b=pMsoAz06w/phUVYM7JwubA8j+YpTsaq30M9Eu1pnumXtYZ9tyjSmx2xMVMd5EYzYk5 AJRWf8OtV24URcSx8yJtFJATBK2NkB4NeyAFSIN6iHQxRs5/ybh9M8aoB9Zq7azXpxvx WHTDEWAADCaQs3zYqcB5Ws8OMgQ4n/+x7LmBGMy+x9cLc8gtqS4plNOg8JcfT8jvwYbz GxvMiBteraxoGS1vUjRL7Iz3v+rbt5q/ItLOjaCSVFcaRbpL8lp1ktq89C4ANDQnYBzs bSt1Sqzldx1vG+871WICbwpEu79h3Jz+sk5z7CvH+KYtEOC8+p9p/4Xz3IX85Zgrtysn C6kw== X-Gm-Message-State: AOAM531kAgfiIbo2teZnEJrKC7l0DPntlySGuEUepa8thhooTZplRFG1 oY0cAbC4nqhuNceYSJjUOw6w1je1zeKTPWXAvDKaaRKcEDl92Q== X-Received: by 2002:a63:ec4c:: with SMTP id r12mr26219212pgj.74.1600437674556; Fri, 18 Sep 2020 07:01:14 -0700 (PDT) MIME-Version: 1.0 References: <20200909102640.1657622-1-warthog618@gmail.com> <20200909102640.1657622-10-warthog618@gmail.com> <20200918124408.GB24657@sol> In-Reply-To: <20200918124408.GB24657@sol> From: Andy Shevchenko Date: Fri, 18 Sep 2020 17:00:56 +0300 Message-ID: Subject: Re: [PATCH v8 09/20] gpiolib: cdev: support edge detection for uAPI v2 To: Kent Gibson Cc: Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , Bartosz Golaszewski , Linus Walleij Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 18, 2020 at 3:44 PM Kent Gibson wrote: > On Tue, Sep 15, 2020 at 01:39:41PM +0300, Andy Shevchenko wrote: > > On Wed, Sep 9, 2020 at 1:33 PM Kent Gibson wrote: > > > > > > Add support for edge detection to lines requested using > > > GPIO_V2_GET_LINE_IOCTL. > > > > > > The edge_detector implementation is based on the v1 lineevent > > > implementation. > Thanks for all the review comments. I'm hoping to address them and get > a v9 out in the next few days. Do you have any comments for the > remaining patches - particularly 10-12 that complete the kernel > implementation? Probably. I will do my best to review the rest, though I've been quite overloaded the last few weeks with different stuff. -- With Best Regards, Andy Shevchenko