Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1252759pxk; Fri, 18 Sep 2020 07:46:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9nA8hjMw+1ssX4oyXy0oYKcuik0Hjgw7Z74qY8QMJ8Ca916+qt7NEIvgQu5DRdXySvyWA X-Received: by 2002:aa7:c148:: with SMTP id r8mr40045891edp.210.1600440388233; Fri, 18 Sep 2020 07:46:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600440388; cv=none; d=google.com; s=arc-20160816; b=jVfxiYDVx5pCDgmc2LwFv2LYnyHq+RfcWsN9AWMngRyghJZ6O8YGTsNJ3zVzbhbz+M 9e0AUI58QOeYaV5kN8mqg1K5mW5W/pbQCcGkhogb1QnLxFbiWfADUuHmWJCYwVxRxYD7 GqT54BSIBq5CJuJJ+ncp9fdKfm38f9KpfG6rUIMrWLFuUKO1niMmUvX8SAIyNFzqjgi8 aj2+E1MAJEYkY12PRLFrn/n1XkP+ZLQd1xOxWlGlBdB20IPzoGNlfTIUHrl94S6gLaiz W/5Cm6GdyIh1oRywwQZyVftXtuEdJv1xTD3tVAAl9e3oaftea9TKYT+VmCFwKlmE4d9h FVlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=6NiKzp3GYnVNlrj1nKLgBBFJ1a03bOSILhGt3u/+Pok=; b=thcQf584pk5Mk2CneDqdMsTDIOl/0WhQWEkfR5zjxMtN1p0oICkDSwzjm++I79qXiu wrhdXRIkFkdzw6um4JU2Ff9Spp6eMQQ0S+WxXM63IG59exsWogsowFmRMmY8iJKVGsbg 00tOK4w5eb+OO7YzfNG9f+iJfvdNDPt9avWtsk8AnYbYgZjkror6GOf46ohtW38fi5S6 tIQYkLS1BiiQsfzcWenxtR7PluIHJYSZLyJ5wtR7MRLlM/3XPXiaZ90JOAwROGcZmR1z oEWzWeMQX7QKfARnv+Al/cP+/+IxX5QydkKF0nSjc49XIVmzOahqCVPiSQiX1nXu9Jo9 K1cQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=XIp6kndV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lz9si2335501ejb.618.2020.09.18.07.46.04; Fri, 18 Sep 2020 07:46:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=XIp6kndV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726629AbgIROoc (ORCPT + 99 others); Fri, 18 Sep 2020 10:44:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725955AbgIROoc (ORCPT ); Fri, 18 Sep 2020 10:44:32 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8C75C0613CE for ; Fri, 18 Sep 2020 07:44:31 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id w2so5589233wmi.1 for ; Fri, 18 Sep 2020 07:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6NiKzp3GYnVNlrj1nKLgBBFJ1a03bOSILhGt3u/+Pok=; b=XIp6kndVEG2N2+RGvk2CLTkKWfRU+U5aAp7NUBTHXY8UWtgpV3qgnO6RIrKMJP2gtz zirQylm1yKbgnZxlriyNfUVIaDLWf4G84eDl5CnQNKUWfoRInb8kZRK9KDBDK2khyC6j QEQ1CtSCDRHUIXTobBj4jhMHt6V8yVSBE8UcDUqWlt1em7Ef90dKhlzHeN1No1G4zCBl NeM9HvHya5j56QPjDMQhy6xDxEmDoAxKDxIbds8HUqMCsfdg5TZgEpm9xikP/ip6Z32a r+FXgb8s4aCv3lU3KmOPVPxLv4cZXqc05XtlByqTDPNAUqIQrmG6wp2rERCitlLOsLJV kqsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6NiKzp3GYnVNlrj1nKLgBBFJ1a03bOSILhGt3u/+Pok=; b=ujRn+4wN1imVhFfwJ5EtlhOocNm+Q+NO5xo/tWOn/F2RFK3BMqJGMHxg/Nqc8J/LZZ +4/Bj1v8L+w0yiQ/izPAXZo3y748ZcKEARPuZGSMTsT6tYHOQngAmqjIK9xhvUOUCoA9 vmM2g1fqto9JOd1wcvg2FWTHW2oH0Co/WAsYrqkWvllpY7PsilkmkV+Dbi5u21/ao1Ak CLcTBLN6uNMobNVKIsXrjGQc8CdEQ2jopnYbRDY66RWqlzZYp8jIcVlnjkx3WRuglZZb K/9JOCzRCQ4PplJMpHX17qprlod5Tr4HIkIyUGP0HBoDDI7n2Hv3q4NrEbTm21Daw17i e28w== X-Gm-Message-State: AOAM530XEg3zetWlY5lm7P6oiT89Inntpc4yJdBOL6U+luiuP9BzrsJa Shm6wg2/eQt5CWNE5dU4m+HncA== X-Received: by 2002:a1c:a953:: with SMTP id s80mr15793418wme.70.1600440270291; Fri, 18 Sep 2020 07:44:30 -0700 (PDT) Received: from elver.google.com ([100.105.32.75]) by smtp.gmail.com with ESMTPSA id s17sm5860736wrr.40.2020.09.18.07.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 07:44:29 -0700 (PDT) Date: Fri, 18 Sep 2020 16:44:23 +0200 From: Marco Elver To: Andrey Konovalov Cc: Dmitry Vyukov , Vincenzo Frascino , Catalin Marinas , kasan-dev@googlegroups.com, Andrey Ryabinin , Alexander Potapenko , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 35/37] kasan, slub: reset tags when accessing metadata Message-ID: <20200918144423.GF2384246@elver.google.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.14.4 (2020-06-18) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 11:16PM +0200, Andrey Konovalov wrote: [...] > static void set_track(struct kmem_cache *s, void *object, > @@ -583,7 +585,8 @@ static void set_track(struct kmem_cache *s, void *object, > unsigned int nr_entries; > > metadata_access_enable(); > - nr_entries = stack_trace_save(p->addrs, TRACK_ADDRS_COUNT, 3); > + nr_entries = stack_trace_save(kasan_reset_tag(p->addrs), > + TRACK_ADDRS_COUNT, 3); Suggested edit (below 100 cols): - nr_entries = stack_trace_save(kasan_reset_tag(p->addrs), - TRACK_ADDRS_COUNT, 3); + nr_entries = stack_trace_save(kasan_reset_tag(p->addrs), TRACK_ADDRS_COUNT, 3);