Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 18 Sep 2020 09:56:19 -0500
From:   "Gustavo A. R. Silva" <gustavoars@kernel.org>
To:     Jing Xiangfeng <jingxiangfeng@huawei.com>
Cc:     jejb@linux.ibm.com, martin.petersen@oracle.com,
        lee.jones@linaro.org, colin.king@canonical.com, axboe@kernel.dk,
        mchehab+huawei@kernel.org, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: arcmsr: Remove the superfluous break
Message-ID: <20200918145619.GA25599@embeddedor>
References: <20200918093230.49050-1-jingxiangfeng@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200918093230.49050-1-jingxiangfeng@huawei.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Fri, Sep 18, 2020 at 05:32:30PM +0800, Jing Xiangfeng wrote:
> Remove the superfluous break, as there is a 'return' before it.
>

Apparently, the change is correct. Please, just add a proper Fixes tag by
yourself this time.

Thanks
--
Gustavo

> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
>  drivers/scsi/arcmsr/arcmsr_hba.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
> index ec895d0319f0..74add6d247d5 100644
> --- a/drivers/scsi/arcmsr/arcmsr_hba.c
> +++ b/drivers/scsi/arcmsr/arcmsr_hba.c
> @@ -2699,10 +2699,8 @@ static irqreturn_t arcmsr_interrupt(struct AdapterControlBlock *acb)
>  	switch (acb->adapter_type) {
>  	case ACB_ADAPTER_TYPE_A:
>  		return arcmsr_hbaA_handle_isr(acb);
> -		break;
>  	case ACB_ADAPTER_TYPE_B:
>  		return arcmsr_hbaB_handle_isr(acb);
> -		break;
>  	case ACB_ADAPTER_TYPE_C:
>  		return arcmsr_hbaC_handle_isr(acb);
>  	case ACB_ADAPTER_TYPE_D:
> -- 
> 2.17.1
>