Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after
 memory hotplug as expected by khugepaged
To:     Michal Hocko <mhocko@suse.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Oleg Nesterov <oleg@redhat.com>,
        Song Liu <songliubraving@fb.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Pavel Tatashin <pasha.tatashin@soleen.com>,
        Allen Pais <apais@microsoft.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
References: <1599770859-14826-1-git-send-email-vijayb@linux.microsoft.com>
 <20200914143312.GU16999@dhcp22.suse.cz>
 <c6fcc196-ce7f-1f48-e9bd-c18448272df1@linux.microsoft.com>
 <20200915081832.GA4649@dhcp22.suse.cz>
 <53dd1e2c-f07e-ee5b-51a1-0ef8adb53926@linux.microsoft.com>
 <20200916065306.GB18998@dhcp22.suse.cz>
 <32b73685-48f2-b6dd-f000-8ea52cfee70a@linux.microsoft.com>
 <20200917121213.GC29887@dhcp22.suse.cz>
 <7eddcc58-f65f-0be9-60e8-2de013365909@linux.microsoft.com>
 <20200918054513.GA28827@dhcp22.suse.cz>
From:   Vijay Balakrishna <vijayb@linux.microsoft.com>
Message-ID: <2bd9ebf5-f6b7-1a2a-be61-9d4af8210cce@linux.microsoft.com>
Date:   Fri, 18 Sep 2020 08:32:13 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.2.2
MIME-Version: 1.0
In-Reply-To: <20200918054513.GA28827@dhcp22.suse.cz>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/17/2020 10:45 PM, Michal Hocko wrote:
> On Thu 17-09-20 11:03:56, Vijay Balakrishna wrote:
> [...]
>>>> The auto tuned value is incorrect post hotplug memory operation, in our use
>>>> case memoy hot add occurs very early during boot.
>>> Define incorrect. What are the actual values? Have you tried to increase
>>> the value manually after the hotplug?
>>
>> In our case SoC with 8GB memory, system tuned min_free_kbytes
>> - first to 22528
>> - we perform memory hot add very early in boot
> 
> What was the original and after-the-hotplug size of memory and layout?
> I suspect that all the hotplugged memory is in Movable zone, right?

Yes, added ~1.92GB as Movable type, booting with 6GB at start.

> 
>> - now min_free_kbytes is 8703
>>
>> Before looking at code, first I manually restored min_free_kbytes soon after
>> boot, reran stress and didn't notice symptoms I mentioned in change log.
> 
> This is really surprising and I strongly suspect that an earlier reclaim
> just changed the timing enough so that workload has spread the memory
> prpessure over a longer time and that might have been enough to recycle
> some of the unreclaimable memory due to its natural life time. But this
> is a pure speculation. Much more data would be needed to analyze this.
> 
> In any case your stress test is oveprovisioning your Normal zone and
> increased min_free_kbytes just papers over the sizing problem.
> 

It is a synthetic workload, likely not sized I need to check.  I feel 
having higher min_free_kbytes made GFP_ATOMIC allocations not to fail. 
I have seen NETDEV WATCHDOG timeout with stacktrace trying to allocate 
memory, looping in net rx receive path.

Thanks,
Vijay