Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200905080920.13396-1-yong.wu@mediatek.com> <20200905080920.13396-2-yong.wu@mediatek.com>
 <20200914232204.GA457962@bogus> <1600148980.25043.11.camel@mhfsdcap03>
In-Reply-To: <1600148980.25043.11.camel@mhfsdcap03>
From:   Rob Herring <robh@kernel.org>
Date:   Fri, 18 Sep 2020 10:07:51 -0600
Message-ID: <CAL_JsqKj+-_vvZfoLiJ-ox255cFaAD4SPmrk2qCusGWAs-b+XQ@mail.gmail.com>
Subject: Re: [PATCH v2 01/23] dt-bindings: iommu: mediatek: Convert IOMMU to
 DT schema
To:     Yong Wu <yong.wu@mediatek.com>
Cc:     Joerg Roedel <joro@8bytes.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Will Deacon <will@kernel.org>,
        Evan Green <evgreen@chromium.org>,
        Tomasz Figa <tfiga@google.com>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        srv_heupstream <srv_heupstream@mediatek.com>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Linux IOMMU <iommu@lists.linux-foundation.org>,
        Youlin Pei <youlin.pei@mediatek.com>,
        Nicolas Boichat <drinkcat@chromium.org>,
        Anan Sun <anan.sun@mediatek.com>,
        Chao Hao <chao.hao@mediatek.com>,
        Ming-Fan Chen <ming-fan.chen@mediatek.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Sep 14, 2020 at 11:51 PM Yong Wu <yong.wu@mediatek.com> wrote:
>
> On Mon, 2020-09-14 at 17:22 -0600, Rob Herring wrote:
> > On Sat, Sep 05, 2020 at 04:08:58PM +0800, Yong Wu wrote:
> > > Convert MediaTek IOMMU to DT schema.
> > >
> > > Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> > > ---
>
> [...]
>
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - mediatek,mt2701-m4u #mt2701 generation one HW
> > > +      - mediatek,mt2712-m4u #mt2712 generation two HW
> > > +      - mediatek,mt6779-m4u #mt6779 generation two HW
> > > +      - mediatek,mt7623-m4u, mediatek,mt2701-m4u #mt7623 generation one HW
> >
> > This is not right.
> >
> > items:
> >   - const: mediatek,mt7623-m4u
> >   - const: mediatek,mt2701-m4u
> >
> > And that has to be under a 'oneOf' with the rest of this.
>
> Thanks for the review. Is this OK?
>
>   compatible:
>     oneOf:
>       - const: mediatek,mt2701-m4u # mt2701 generation one HW
>       - const: mediatek,mt2712-m4u # mt2712 generation two HW
>       - const: mediatek,mt6779-m4u # mt6779 generation two HW
>       - const: mediatek,mt8173-m4u # mt8173 generation two HW
>       - const: mediatek,mt8183-m4u # mt8183 generation two HW
>       - const: mediatek,mt8192-m4u # mt8192 generation two HW

It is correct, but I prefer all these to be a single enum. So 'oneOf'
would have 2 entries.

>       - description: mt7623 generation one HW
>         items:
>           - const: mediatek,mt7623-m4u
>           - const: mediatek,mt2701-m4u
>
> >
> > > +      - mediatek,mt8173-m4u #mt8173 generation two HW
> > > +      - mediatek,mt8183-m4u #mt8183 generation two HW
> > > +
> > > +  reg:
> > > +    maxItems: 1
>
> [snip]