Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 18 Sep 2020 12:20:08 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Miroslav Benes <mbenes@suse.cz>
Cc:     mingo@redhat.com, peterz@infradead.org, adrian.hunter@intel.com,
        linux-kernel@vger.kernel.org, mhiramat@kernel.org
Subject: Re: [PATCH] ftrace: Free the trampoline when ftrace_startup() fails
Message-ID: <20200918122008.7b21f77e@gandalf.local.home>
In-Reply-To: <alpine.LSU.2.21.2008311455440.16475@pobox.suse.cz>
References: <20200831122631.28057-1-mbenes@suse.cz>
        <alpine.LSU.2.21.2008311455440.16475@pobox.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 31 Aug 2020 14:56:57 +0200 (CEST)
Miroslav Benes <mbenes@suse.cz> wrote:

> I used Masami's address which did not work. Sorry about that. Should be ok 
> now.

Thanks Miroslav,

I've queued this up to be tested and pushed as urgent.

-- Steve

> 
> On Mon, 31 Aug 2020, Miroslav Benes wrote:
> 
> > Commit fc0ea795f53c ("ftrace: Add symbols for ftrace trampolines")
> > missed to remove ops from new ftrace_ops_trampoline_list in
> > ftrace_startup() if ftrace_hash_ipmodify_enable() fails there. It may
> > lead to BUG if such ops come from a module which may be removed.
> > 
> > Moreover, the trampoline itself is not freed in this case.
> > 
> > Fix it by calling ftrace_trampoline_free() during the rollback.
> > 
> > Fixes: fc0ea795f53c ("ftrace: Add symbols for ftrace trampolines")
> > Signed-off-by: Miroslav Benes <mbenes@suse.cz>
> > ---
> >