Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Fri, 18 Sep 2020 10:08:43 -0700
From:   bbhatt@codeaurora.org
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
        hemantk@codeaurora.org, jhugo@codeaurora.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/3] bus: mhi: core: Introduce debugfs entries for MHI
In-Reply-To: <bf24b8fe-8ff3-4ff3-a1f0-c276dcc5832c@infradead.org>
References: <1600381176-37604-1-git-send-email-bbhatt@codeaurora.org>
 <1600381176-37604-3-git-send-email-bbhatt@codeaurora.org>
 <bf24b8fe-8ff3-4ff3-a1f0-c276dcc5832c@infradead.org>
Message-ID: <59df7b450303542c498ff845ea171be4@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2020-09-17 16:36, Randy Dunlap wrote:
> On 9/17/20 3:19 PM, Bhaumik Bhatt wrote:
>> diff --git a/drivers/bus/mhi/Kconfig b/drivers/bus/mhi/Kconfig
>> index a8bd9bd..ae68347 100644
>> --- a/drivers/bus/mhi/Kconfig
>> +++ b/drivers/bus/mhi/Kconfig
>> @@ -12,3 +12,11 @@ config MHI_BUS
>>  	 communication protocol used by the host processors to control
>>  	 and communicate with modem devices over a high speed peripheral
>>  	 bus or shared memory.
>> +
>> +config MHI_BUS_DEBUG
>> +       bool "Debugfs support for the MHI bus"
>> +       depends on MHI_BUS && DEBUG_FS
>> +       help
>> +	 Enable debugfs support for use with the MHI transport. Allows
>> +	 reading and/or modifying some values within the MHI controller
>> +	 for debug and test purposes.
> 
> from Documentation/process/coding-style.rst:
> 
> """For all of the Kconfig* configuration files throughout the source 
> tree,
> the indentation is somewhat different.  Lines under a ``config`` 
> definition
> are indented with one tab, while help text is indented an additional 
> two
> spaces."""
> 
> Several lines above use spaces instead of one tab...
Thank you for pointing out. I will fix this.