Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751303AbWHBHPn (ORCPT ); Wed, 2 Aug 2006 03:15:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751304AbWHBHPn (ORCPT ); Wed, 2 Aug 2006 03:15:43 -0400 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:48792 "EHLO ebiederm.dsl.xmission.com") by vger.kernel.org with ESMTP id S1751303AbWHBHPm (ORCPT ); Wed, 2 Aug 2006 03:15:42 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Andi Kleen Cc: linux-kernel@vger.kernel.org, Horms , Jan Kratochvil , "H. Peter Anvin" , Magnus Damm , Vivek Goyal , Linda Wang Subject: Re: [PATCH 9/33] i386 boot: Add serial output support to the decompressor References: <200608020510.07569.ak@suse.de> <200608020744.40888.ak@suse.de> Date: Wed, 02 Aug 2006 01:14:08 -0600 In-Reply-To: <200608020744.40888.ak@suse.de> (Andi Kleen's message of "Wed, 2 Aug 2006 07:44:40 +0200") Message-ID: User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1087 Lines: 38 Andi Kleen writes: > >> The function pointers in the console structure are also a problem. >> static struct console simnow_console = { >> .name = "simnow", >> .write = simnow_write, >> .flags = CON_PRINTBUFFER, >> .index = -1, >> }; > > Yes just patch them at runtime. I guess that can work. It's a bit of a pain though. >> Ideally the code would be setup so you can compile out consoles >> the user finds uninteresting. > > Seems overkill for early_printk At least compiling completely out probably isn't. I have had too many times where the size of a bzImage was an important factor on a project. >> It is annoying to have to call strlen on all of the strings >> you want to print.. > > What strlen? The strlen that is needed to convert putstr(char *s) into the write method for the early_printk helpers. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/