Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1388724pxk; Fri, 18 Sep 2020 11:04:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySCQeyvewFWPKWebt1xBFt5Jz2KTe3FqngY44zGT4tlZAWw89oAepZ6YZmiUrjSYX75KHP X-Received: by 2002:a17:906:e4c:: with SMTP id q12mr36496076eji.425.1600452299490; Fri, 18 Sep 2020 11:04:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600452299; cv=none; d=google.com; s=arc-20160816; b=wOmga39XwfoqfaSNqRmCR9jU3ah+VxwPzej5O56xWldH3lUzKFaRPs0puuf9s4YgTm 91oLQvB2vs3/aosxzEB2eKLS3u187ZOq+2hgbMEWJ70LaT9d14lrWH7e+AFRLdodXX5m 5fWkadRu7HqwGXxf1JQdCADgB7YJhLVF9N+f9BNIPOMdAUa/kh4EhwA2mvMZHRTtm3Gw CZnMZi5HdA4oQ3C/Fli9btuYIZL3OuQvdm3ProvPqpmf70cOrZMBxRPOdXhrs9w27sUk P2XCbz5Sl1cSLJnj+jWrx7HeQIUtqditDKjOlVvBXteiQNtuVoX4b5va6W9uS9JL6mfa 9+DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=8t9bvmNa7HAbT/T846NG8EsOFIharYS9N7nOuLhuASw=; b=JbaCm6VaStxnM2PwQ2d5ijPtXEWBZLrQe5p0G6BDZz2zFomQ00eN4rt7/QqrPTgcNr HBMmL5FhTWXDWMogCY2kotvM1b0inGHgbmd48JxKY27k5uO1eB+rRUEQPu9EwXr7+kCU YvDQ/T5BZBUj4gR7wASe+vQvlH28nxEgcZ30KhZ/M+n98oN/fwCWbw5ghRq4bZXwYTYs gJ5UTJ/60Gq4fRdFlqbcjvWCcZkfQXvWCRzxiWtjW7uwYC/xytJTgAAb8TLsLmq5EJg/ uZj51oOjVI8b79xoaBn8pzX1OFLlA6nLNjo2QEwkZIlelGOuvL8zC8NCvIDvbDZiY8Q8 Zh7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=Ghs8eMA7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s22si2681666ejr.179.2020.09.18.11.04.34; Fri, 18 Sep 2020 11:04:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=Ghs8eMA7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726321AbgIRSBZ (ORCPT + 99 others); Fri, 18 Sep 2020 14:01:25 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:43026 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726118AbgIRSBY (ORCPT ); Fri, 18 Sep 2020 14:01:24 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08IHxlJD120269; Fri, 18 Sep 2020 18:00:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=8t9bvmNa7HAbT/T846NG8EsOFIharYS9N7nOuLhuASw=; b=Ghs8eMA73OKyFYU2sieQPHJz7IQr2Z0/Kg+q7d8eI5ZxZnxCQ/xud0UxSMOUTH3T5wvC 9azCJpe81SMpW5Sp1Vmi7eAFcPewOC2/vDXOle6dOsSK9M9Yo0GMvHQ4x5QO2ROlkaAL xrENiDW7hnnyoDw7ycTtWxE9iG3V3SPZEa6GytTZ61CAN96ui+MX4QCUdT3t0F0Y9Jg3 53JO0ye4C7zXvcsnXCI3bpAV9utvVlV5OC4743z0NprMIrFvtBFKSCMNWWllRO9+ozQH 9ULw6hcAxXd1Ms+NGzeosKXMqan3PQIwuJc4TFlEXPmr6/a2l5ZLKCGWTB736J+S4Mp3 9A== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 33gnrrgpb5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 18 Sep 2020 18:00:51 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08II0APH140452; Fri, 18 Sep 2020 18:00:50 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 33khpq2kxy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Sep 2020 18:00:50 +0000 Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08II0jFm028734; Fri, 18 Sep 2020 18:00:46 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 18 Sep 2020 18:00:45 +0000 Date: Fri, 18 Sep 2020 21:00:37 +0300 From: Dan Carpenter To: Joe Perches Cc: "Gustavo A. R. Silva" , Jing Xiangfeng , jejb@linux.ibm.com, martin.petersen@oracle.com, lee.jones@linaro.org, colin.king@canonical.com, axboe@kernel.dk, mchehab+huawei@kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors Subject: Re: [PATCH] scsi: arcmsr: Remove the superfluous break Message-ID: <20200918180037.GY4282@kadam> References: <20200918093230.49050-1-jingxiangfeng@huawei.com> <20200918145619.GA25599@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9748 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 mlxlogscore=999 phishscore=0 mlxscore=0 adultscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009180147 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9748 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 mlxscore=0 bulkscore=0 suspectscore=0 clxscore=1011 mlxlogscore=999 adultscore=0 priorityscore=1501 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009180147 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Smatch just ignores these because they're often done deliberately. regards, dan carpenter