Message-ID: <44D05821.1040209@sgi.com>
Date: Wed, 02 Aug 2006 09:45:37 +0200
From: Jes Sorensen <jes@sgi.com>
User-Agent: Thunderbird 1.5.0.4 (X11/20060527)
MIME-Version: 1.0
To: Andrew Morton <akpm@osdl.org>
CC: nagar@watson.ibm.com, jlan@sgi.com, linux-kernel@vger.kernel.org,
       balbir@in.ibm.com, csturtiv@sgi.com, tee@sgi.com
Subject: Re: [patch 3/3] convert CONFIG tag for a few accounting data used
 by CSA
References: <44CE58AF.7030200@sgi.com>	<44CE6AE7.8020304@watson.ibm.com>	<44D0538A.3090600@sgi.com> <20060802003102.c8cb1a47.akpm@osdl.org>
In-Reply-To: <20060802003102.c8cb1a47.akpm@osdl.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 849
Lines: 24

Andrew Morton wrote:
> On Wed, 02 Aug 2006 09:26:02 +0200
> Jes Sorensen <jes@sgi.com> wrote:
>> Shailabh Nagar wrote:
>>> static inlines preferred
>> Huh? Is that a preference to the taskstat project? For the kernel
>> itself it makes no difference.
> 
> static inlines provide typechecking and typo checking and presence-of-x
> checking when the option is configged off.  They can also suppress unused
> variable warnings.
> 
> And they're C, not cpp ;)

That I agree with, I guess I normally just draw the line between
functions that do actual work versus empty dummies like in this case.

Cheers,
Jes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/