Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1490491pxk; Fri, 18 Sep 2020 14:05:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBKAd4UQ/Q0Xn58Wh5gwv6G+tJjwRWE3xKZVfOqCnsWM95u88B3rdAWpuP9keenWAsgjd5 X-Received: by 2002:a17:906:56c2:: with SMTP id an2mr38637171ejc.118.1600463105349; Fri, 18 Sep 2020 14:05:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600463105; cv=none; d=google.com; s=arc-20160816; b=hhV67t248WR6Jjgv+DvYvfeZwNGiF166E+K/kssI+IFgPgiM9hiSZX9hs6MXsBWQja QXHkWeTsBTL5ioSy476+5SrVQeGxrriHaXJuaM5wmpTewtWw/A4w0PK3SBBuSPSrYQ4l Bz7MSgCl7NlkYRkxDsZpCbUc/59dmLIQdpl+DrqqBLaKURsEl1ElfuHzVFk9OUAgC6d1 M4UEwIdbBYE2xFHt00SI0zb8ZaePiRXGUWbhLxSIOVwAFu0ROm2xqlnsSPheDWoizhUr Iixb0KlCLWrmhLUI1zhTvzG4eegtQlfbRn2LOQCX/1NUPyl0lD5svOJNZaBLhMXJIksQ ygLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=VMdfQBiPkVgrNkdviS6FDWdksiCikGERGSW0/sd9Dnc=; b=J9LIrL5kYzD/+SruYnaBpLehZ+4bgWtvhSd4wCibfA6YFJ2C8byYCyMKbMg8qO8NDO 14Zl/um48yr2B2XF6VPgVv3Zof4d0HWBdwnbkFDSW3trr8/QKH7bFQa43nL6UrS+GPrP aDc6InPRmWzD9a1knb5OqCcLLY9kBTF92c0P9FldWkui0Uj0nXlpJ2+eJzoBniB/ROly +XWrBqZk0GYAsxksu7PDT6NNQ8ppKlJcOIQa8SE1/VlgggGm0Apug3vIGmad5c49/8is yFm//XdNlCAp7hGB0Cjd9yvCr+3mNq0oSxuoZwRVkAmQaZDirbpOKGw5zzc4TLWiNLcJ POQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z10si3095802ejj.296.2020.09.18.14.04.42; Fri, 18 Sep 2020 14:05:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726218AbgIRVD1 (ORCPT + 99 others); Fri, 18 Sep 2020 17:03:27 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:33130 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726118AbgIRVD0 (ORCPT ); Fri, 18 Sep 2020 17:03:26 -0400 X-Greylist: delayed 399 seconds by postgrey-1.27 at vger.kernel.org; Fri, 18 Sep 2020 17:03:25 EDT Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id B1ABB1C0B7C; Fri, 18 Sep 2020 22:56:43 +0200 (CEST) Date: Fri, 18 Sep 2020 22:56:43 +0200 From: Pavel Machek To: Grygorii Strashko Cc: "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Ulf Hansson , Vincent Guittot , Len Brown , linux-kernel@vger.kernel.org Subject: Re: [PATCH] pm: runtime: fix timer_expires on 32bits arch Message-ID: <20200918205643.GA4304@duo.ucw.cz> References: <20200918165518.23246-1-grygorii.strashko@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline In-Reply-To: <20200918165518.23246-1-grygorii.strashko@ti.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2020-09-18 19:55:18, Grygorii Strashko wrote: > The commit 8234f6734c5d ("PM-runtime: Switch autosuspend over to using > hrtimers") switched PM runtime autosuspend to use hrtimers and all related > time accounting in ns, but missed update the struct > dev_pm_info->timer_expires to u64. This causes timer_expires value to be > truncated on 32bits architectures when assignment is done from u64 values: >=20 > rpm_suspend() > |- dev->power.timer_expires =3D expires; >=20 > Hence, fix it by changing timer_expires type to u64. >=20 > Cc: Vincent Guittot > Fixes: 8234f6734c5d ("PM-runtime: Switch autosuspend over to using hrtime= rs") > Signed-off-by: Grygorii Strashko Acked-by: Pavel Machek --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --AhhlLboLdkugWU4S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCX2UfCwAKCRAw5/Bqldv6 8gOOAKDAEBNUkiCrXacorVsvRCQSjhXbowCfcQxJkV+gbZcAwF3Y0JyY0GZPXBE= =VqJV -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S--