Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1498540pxk;
        Fri, 18 Sep 2020 14:19:24 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJy8fXW6WUQCUt7i5+JEg/EEbQ1yxQ1Q7TWjn6V4YuSpCBo6YLzq3dotkBoMztFy5VdXIWkC
X-Received: by 2002:a05:6402:6c9:: with SMTP id n9mr40806592edy.297.1600463964445;
        Fri, 18 Sep 2020 14:19:24 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1600463964; cv=none;
        d=google.com; s=arc-20160816;
        b=gPFH3ESnr4iQVN95EsldekxdS5bWPrRbW3k1HvthHn32l3sGF+uJ7KWOvQML/mJa6b
         Zrl7z9KVLKc2NvKTomWGcM3D0U8T0r5IMnIyoOdyVxNo3Teo0uOp1j0m3HXISDuRUxCt
         zEAFIqAVCr85gklp/TWUfG40iuBvZbXrr1gcSUv2St6gx1FNTsW7GXBmzahAMDfX7jFp
         OBStPTbkK79h8ndiXQaHTmGuSNndKQiJytthyBFXwHtj8NyXhUqqkrcgO2uZgkBZcY1q
         KKsnodGolhSr5iydxnrUN2uPTzu7Ntb4Ulb792ZGVbZQq3kGTCdLjl0DuaNWZa/U/GQP
         qTpg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=KGNjT4+Au3E3AJwyRDD457odFyJ8TSekKh2G3CnlYbU=;
        b=Nu9F2kk5njJkWLyIkkoVq2M13fJI8F6p8+mqw+3T7/V3w/4l6H94IWnAn5R5HkWHKI
         cNmZwx6KvQg4zpOZ6Uy5X1uWo6Q97k/rFOBEW8NxvJeYhqAiwzqsh35oYoTyUHaUkbnl
         gX/8D6btLf6gnco0UP+v+YlcUBVxp21X4u3I1aRNncb25YnYyQyXTwgftAGKwakLUFut
         WS9/LRzv38DHwzZRlX7Akg/ipIllritzaz9Nff58J9vAGjxFyQdH6pvuh9VbhJReZNwl
         9cogTyEd7NrF5LfI/D/aGofmTYy7GeRDqOs4pCwtd4e+fA93NguY+nKoFOfIsEHhwYX/
         TULA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id d3si3013026ejm.474.2020.09.18.14.19.01;
        Fri, 18 Sep 2020 14:19:24 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726371AbgIRVP5 (ORCPT <rfc822;kkoh.linux@gmail.com>
        + 99 others); Fri, 18 Sep 2020 17:15:57 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34196 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726118AbgIRVP5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 18 Sep 2020 17:15:57 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03AABC0613CE;
        Fri, 18 Sep 2020 14:15:57 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 931311595B401;
        Fri, 18 Sep 2020 13:59:09 -0700 (PDT)
Date:   Fri, 18 Sep 2020 14:15:56 -0700 (PDT)
Message-Id: <20200918.141556.1367737647918813478.davem@davemloft.net>
To:     hankinsea@gmail.com
Cc:     richardcochran@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ptp: mark symbols static where possible
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200918061013.2034-1-hankinsea@gmail.com>
References: <20200918061013.2034-1-hankinsea@gmail.com>
X-Mailer: Mew version 6.8 on Emacs 27.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Fri, 18 Sep 2020 13:59:09 -0700 (PDT)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Herrington <hankinsea@gmail.com>
Date: Fri, 18 Sep 2020 14:10:13 +0800

> +void pch_ch_control_write(struct pci_dev *pdev, u32 val);
>  void pch_ch_control_write(struct pci_dev *pdev, u32 val)

Prototypes belong in a header file not in the C file where they
are defined.

If these functions are accessed in other foo.c files, they are
getting the prototype from some header file.

Otherwise they aren't, and the functions should be marked
static.