Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1594638pxk; Fri, 18 Sep 2020 17:48:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXgDgSs91dwwSoZqxhj8QFtQZIsXrVocL7tqfKIMuTrQ2vkix1EBvi2uxmbdPm2qwNQgfz X-Received: by 2002:a17:906:16da:: with SMTP id t26mr38014583ejd.172.1600476507971; Fri, 18 Sep 2020 17:48:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600476507; cv=none; d=google.com; s=arc-20160816; b=Iv+8y1BbPJZfUFDMgkvMzRfqCjt2Tl78qLE2tTQiNjwPa41P67UK6nYkkM1fRqkiZo jEVSg7whT5FSQUcKvJam3akxqSBrrzNguNBb7HUfPk2ad0GzNnJWc/gopILwLsk8SWxc EQ9rFNrKvVhww/h5eKVUXG5m//bED2zXZH8OLK4G5fY4hY02ZSSphdnaqG0eIeDINh52 JcqqlR6LRmXV0JGIeywqQlBFFl4jw5p5Xbzfes0YRBkZOg8xbR2th1O4v9QGNTHfBeri YTXkbRhBv5GWlMvgO2K0w9wwEGYULLKxKMHzDIbu6bNrC1i0XsZyyEaIYZk2bA7Yl8y6 40zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=JTZTiBLLw01jnNyW5DUn5EfnyZF/RuAEWCqVtyRkgvA=; b=CQONuxez7JVQ6/zxVT6BHQFuI/CFPcoCtkpMv/2zy+Wc41oCk29We1f4pxbdn9qimi YXhMrn1sRqC+/C7BIHLX6J2ysU2LkG4ZkWfQKexSHzt59pTJ8ZunypuICsu+K/lEwsc6 xzcYQ5lRdc2TeAu94T3ALbZ8Hgkoo0dWIHv+NzOIWqJFgis+brMXvUR7FfrFvjeoP0X0 n/Hn29XBZEqrbTBpMpMad+2CFuYWHjMfXqouQ/0A0Ql3iFpv97rUmwFUAZu4BmCh1IlH EgYVD5JWzhRexVc69XDmcfhpQkHVcQdEoXXN4ogB1iN7WVtyQdKcZgbxmkuvU2Qt9nB7 67dA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q11si1060227edh.208.2020.09.18.17.48.04; Fri, 18 Sep 2020 17:48:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726279AbgISApr (ORCPT + 99 others); Fri, 18 Sep 2020 20:45:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726250AbgISApq (ORCPT ); Fri, 18 Sep 2020 20:45:46 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78E08C0613CE; Fri, 18 Sep 2020 17:45:46 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9654E15B38A44; Fri, 18 Sep 2020 17:28:58 -0700 (PDT) Date: Fri, 18 Sep 2020 17:45:44 -0700 (PDT) Message-Id: <20200918.174544.1980981472619221408.davem@davemloft.net> To: fazilyildiran@gmail.com Cc: david.lebrun@uclouvain.be, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, paul@pgazz.com, jeho@cs.utexas.edu Subject: Re: [PATCH] net: ipv6: fix kconfig dependency warning for IPV6_SEG6_HMAC From: David Miller In-Reply-To: <20200917164642.158458-1-fazilyildiran@gmail.com> References: <20200917164642.158458-1-fazilyildiran@gmail.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Fri, 18 Sep 2020 17:28:58 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Necip Fazil Yildiran Date: Thu, 17 Sep 2020 19:46:43 +0300 > When IPV6_SEG6_HMAC is enabled and CRYPTO is disabled, it results in the > following Kbuild warning: > > WARNING: unmet direct dependencies detected for CRYPTO_HMAC > Depends on [n]: CRYPTO [=n] > Selected by [y]: > - IPV6_SEG6_HMAC [=y] && NET [=y] && INET [=y] && IPV6 [=y] > > WARNING: unmet direct dependencies detected for CRYPTO_SHA1 > Depends on [n]: CRYPTO [=n] > Selected by [y]: > - IPV6_SEG6_HMAC [=y] && NET [=y] && INET [=y] && IPV6 [=y] > > WARNING: unmet direct dependencies detected for CRYPTO_SHA256 > Depends on [n]: CRYPTO [=n] > Selected by [y]: > - IPV6_SEG6_HMAC [=y] && NET [=y] && INET [=y] && IPV6 [=y] > > The reason is that IPV6_SEG6_HMAC selects CRYPTO_HMAC, CRYPTO_SHA1, and > CRYPTO_SHA256 without depending on or selecting CRYPTO while those configs > are subordinate to CRYPTO. > > Honor the kconfig menu hierarchy to remove kconfig dependency warnings. > > Fixes: bf355b8d2c30 ("ipv6: sr: add core files for SR HMAC support") > Signed-off-by: Necip Fazil Yildiran Applied and queued up for -stable, thank you.