Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1595400pxk; Fri, 18 Sep 2020 17:50:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzv5oIraQyYaTzpl48mjdx7e+jVNU7NgLM21q41CQHTHH6C6nwte0Dud8nAzz2p1t0LkaeW X-Received: by 2002:a17:906:3748:: with SMTP id e8mr35873356ejc.71.1600476615356; Fri, 18 Sep 2020 17:50:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600476615; cv=none; d=google.com; s=arc-20160816; b=yu0nRIOQ6kgx/lgyyPXdX5qe4Nn4eAKMaMWg1XR1crFGAijXpvRrOzEX6zZm/8hoH2 bXXKt7Uba/eMJcZFVuPfrlfAcUzQ1YPCW6OVJ+VyIs2KfTOubsBxIgMzQMv/LrwfiyMC ANcsNOWG3z5jTj+AsUSnzM5c7a3xSs9OiKiyo5KWt4rwllSGVEkPZ651aPbXge5w8neG +PT8I+CnIrcYf2ndIDgPCCQltBzMu/eG0chp/j6p1JK3Ru61ghH0suQ/Axfq7t0rbCS/ j0gVzN9CJZDRElV45iyrLrIo4kb7SspRexNgsgcnxzZ25JOF0PbZYPkXhAOyO8qliCfV QBtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=/RRENMeDQ6X+9CXXFpZkkNYu+H3dNwCIUhJ8eCMV4nY=; b=be14xLU0oewnvxXvPRbWO30Ke/Wg4gqLoee+hMHsOvl2Pc/gEanoPLs6IaTxEwXWpE yCAwBauFHSQWoOlQxdu6n6liJsT2ivr40m6R8b5Qibhi3E2JXIFJ1jDXwWv465/Gn8Hc pjgebgwYftUbkQzn7GqyPzZ6utX5LwAAVm4bAsZttOtmHwIipbC7D9D5nWn/Jwb68AT7 ++XsAeWSi3NEQ3GrJ23y7OWDZeEaFY4PYJJS4474rx8OTeYvd3PzlJm2fz/L+SkoXzqP zniu/pjqmTa9auicfOlrBISu3w4MRvCTiiNyY4bDq7HoJlpmzoRa+JPxOe7n4DXD7RVA MqVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kuJSQHj6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id pg3si3856068ejb.94.2020.09.18.17.49.51; Fri, 18 Sep 2020 17:50:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kuJSQHj6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726156AbgISArp (ORCPT + 99 others); Fri, 18 Sep 2020 20:47:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:48058 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726054AbgISArp (ORCPT ); Fri, 18 Sep 2020 20:47:45 -0400 Received: from X1 (unknown [67.22.170.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CC4D521D20; Sat, 19 Sep 2020 00:47:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600476465; bh=GFKsAemW7eKRuJ6K11IiY8exAIttJyNQaweQ9T2fkIo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kuJSQHj6kqUn/d6d0FUUL3Wxi5+lt/cxNWDddHZZVy01MHrFaukn+IPCdx1woPla6 PJmxi9Nekevk02mColMXI0b04UuyfG7QcdY3NtDdJwIQhdHO2n6jerN+51Qw6jBT64 oC6Ea1iVCeglIjgWjfSzI6cxispirMrVInuXHP1E= Date: Fri, 18 Sep 2020 17:47:43 -0700 From: Andrew Morton To: Dave Young Cc: bhe@redhat.com, Eric Biederman , linux-kernel@vger.kernel.org, kexec@lists.infradead.org Subject: Re: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time Message-Id: <20200918174743.0994c59f058451948837dcb6@linux-foundation.org> In-Reply-To: <20200918032546.GA4180@dhcp-128-65.nay.redhat.com> References: <20200918032546.GA4180@dhcp-128-65.nay.redhat.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Sep 2020 11:25:46 +0800 Dave Young wrote: > crash_kexec_post_notifiers enables running various panic notifier > before kdump kernel booting. This increases risks of kdump failure. > It is well documented in kernel-parameters.txt. We do not suggest > people to enable it together with kdump unless he/she is really sure. > This is also not suggested to be enabled by default when users are > not aware in distributions. > > But unfortunately it is enabled by default in systemd, see below > discussions in a systemd report, we can not convince systemd to change > it: > https://github.com/systemd/systemd/issues/16661 > > Actually we have got reports about kdump kernel hangs in both s390x > and powerpcle cases caused by the systemd change, also some x86 cases > could also be caused by the same (although that is in Hyper-V code > instead of systemd, that need to be addressed separately). > > Thus to avoid the auto enablement here just disable the param writable > permission in sysfs. > Well. I don't think this is at all a desirable way of resolving a disagreement with the systemd developers At the above github address I'm seeing "ryncsn added a commit to ryncsn/systemd that referenced this issue 9 days ago", "pstore: don't enable crash_kexec_post_notifiers by default". So didn't that address the issue?