Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] i2c: Switch to using the new API kobj_to_dev()
To:     <wsa@kernel.org>, Tian Tao <tiantao6@hisilicon.com>,
        <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linuxarm@huawei.com>
References: <1600133898-35883-1-git-send-email-tiantao6@hisilicon.com>
 <20200918210911.GF52206@kunai>
From:   "tiantao (H)" <tiantao6@huawei.com>
Message-ID: <0f47261e-c80e-a57f-2771-1be5e179a436@huawei.com>
Date:   Sat, 19 Sep 2020 09:01:12 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20200918210911.GF52206@kunai>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2020/9/19 5:09, wsa@kernel.org 写道:
> 
>>   static inline struct i2c_client *kobj_to_i2c_client(struct kobject *kobj)
>>   {
>> -	struct device * const dev = container_of(kobj, struct device, kobj);
>> +	struct device * const dev = kobj_to_dev(kobj);
>>   	return to_i2c_client(dev);
> 
> Can't we make this a oneliner then merging the last two lines?
> 
I think two lines have better readability, and if you prefer one line, I 
can send v2 to fix that!