Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] vfio/pci: Remove redundant declaration of
 vfio_pci_driver
To:     Alex Williamson <alex.williamson@redhat.com>
CC:     <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <cohuck@redhat.com>, <wanghaibin.wang@huawei.com>
References: <20200917033128.872-1-yuzenghui@huawei.com>
 <20200917162240.037a1913@x1.home>
From:   Zenghui Yu <yuzenghui@huawei.com>
Message-ID: <ac4c01e5-df0e-1a18-6a1e-d50f37ddafb7@huawei.com>
Date:   Sat, 19 Sep 2020 09:56:43 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <20200917162240.037a1913@x1.home>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020/9/18 6:22, Alex Williamson wrote:
> On Thu, 17 Sep 2020 11:31:27 +0800
> Zenghui Yu <yuzenghui@huawei.com> wrote:
> 
>> It was added by commit 137e5531351d ("vfio/pci: Add sriov_configure
>> support") and actually unnecessary. Remove it.
> 
> Looks correct, but I might clarify as:
> 
> s/unnecessary/duplicates a forward declaration earlier in the file/
> 
> I can change on commit if you approve.  Thanks,

Indeed. Please help to change it.


Thanks,
Zenghui