Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
AI-Spam-Status: Not processed
Date:   Sat, 19 Sep 2020 15:02:38 +0800
From:   Jiaxun Yang <jiaxun.yang@flygoat.com>
To:     Youling Tang <tangyouling@loongson.cn>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>
CC:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: kexec: Add crashkernel=YM handling
User-Agent: K-9 Mail for Android
In-Reply-To: <1600480546-10448-1-git-send-email-tangyouling@loongson.cn>
References: <1600480546-10448-1-git-send-email-tangyouling@loongson.cn>
Message-ID: <3F79DD89-BE1E-456F-9297-273DDBB4E12A@flygoat.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


=E4=BA=8E 2020=E5=B9=B49=E6=9C=8819=E6=97=A5 GMT+08:00 =E4=B8=8A=E5=8D=889=
:55:46, Youling Tang <tangyouling@loongson=2Ecn> =E5=86=99=E5=88=B0:
>When the kernel crashkernel parameter is specified with just a size,
>we are supposed to allocate a region from RAM to store the crashkernel=2E
>However, MIPS merely reserves physical address zero with no checking
>that there is even RAM there=2E
>
>Fix this by lifting similar code from x86, importing it to MIPS with the
>MIPS specific parameters added=2E In the absence of any platform specific
>information, we allocate the crashkernel region from the first 512MB of
>physical memory (limited to CKSEG0 or KSEG0 address range)=2E
>
>When X is not specified, crash_base defaults to 0 (crashkernel=3DYM@XM)=
=2E
>
>E=2Eg=2E without this patch:
>
>The environment as follows:
>[    0=2E000000] MIPS: machine is loongson,loongson64c-4core-ls7a
>=2E=2E=2E
>[    0=2E000000] Kernel command line: root=3D/dev/sda2 crashkernel=3D96M =
=2E=2E=2E
>
>The warning as follows:
>[    0=2E000000] Invalid memory region reserved for crash kernel
>
>And the iomem as follows:
>00200000-0effffff : System RAM
>  00200000-00b47f87 : Kernel code
>  00b47f88-00dfffff : Kernel data
>  00e60000-01f73c7f : Kernel bss
>1a000000-1bffffff : pci@1a000000
>=2E=2E=2E
>
>With this patch:
>
>After increasing crash_base <=3D 0 handling=2E
>
>And the iomem as follows:
>00200000-0effffff : System RAM
>  00200000-00b47f87 : Kernel code
>  00b47f88-00dfffff : Kernel data
>  00e60000-01f73c7f : Kernel bss
>  04000000-09ffffff : Crash kernel
>1a000000-1bffffff : pci@1a000000
>=2E=2E=2E
>
>Signed-off-by: Youling Tang <tangyouling@loongson=2Ecn>
>---
> arch/mips/kernel/setup=2Ec | 24 +++++++++++++++++++++---
> 1 file changed, 21 insertions(+), 3 deletions(-)
>
>diff --git a/arch/mips/kernel/setup=2Ec b/arch/mips/kernel/setup=2Ec
>index bf5f5ac=2E=2E59a88ea 100644
>--- a/arch/mips/kernel/setup=2Ec
>+++ b/arch/mips/kernel/setup=2Ec
>@@ -477,6 +477,11 @@ early_param("elfcorehdr", early_parse_elfcorehdr);
> #endif
>=20
> #ifdef CONFIG_KEXEC
>+
>+/* 64M alignment for crash kernel regions */
>+#define CRASH_ALIGN	SZ_64M
>+#define CRASH_ADDR_MAX	SZ_512M

Hi Youling

How do you determine the alignment requirement?

Can we relax it?

Thanks=2E

- Jiaxun

>+
> static void __init mips_parse_crashkernel(void)
> {
> 	unsigned long long total_mem;
>@@ -489,9 +494,22 @@ static void __init mips_parse_crashkernel(void)
> 	if (ret !=3D 0 || crash_size <=3D 0)
> 		return;
>=20
>-	if (!memblock_find_in_range(crash_base, crash_base + crash_size, crash_=
size, 1)) {
>-		pr_warn("Invalid memory region reserved for crash kernel\n");
>-		return;
>+	if (crash_base <=3D 0) {
>+		crash_base =3D memblock_find_in_range(CRASH_ALIGN, CRASH_ADDR_MAX,
>+							crash_size, CRASH_ALIGN);
>+		if (!crash_base) {
>+			pr_warn("crashkernel reservation failed - No suitable area found=2E\n=
");
>+			return;
>+		}
>+	} else {
>+		unsigned long long start;
>+
>+		start =3D memblock_find_in_range(crash_base, crash_base + crash_size,
>+						crash_size, 1);
>+		if (start !=3D crash_base) {
>+			pr_warn("Invalid memory region reserved for crash kernel\n");
>+			return;
>+		}
> 	}
>=20
> 	crashk_res=2Estart =3D crash_base;