Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 19 Sep 2020 10:14:13 -0700
User-Agent: K-9 Mail for Android
In-Reply-To: <CALCETrVDqHG2chDsLWBHF39SXh6vjzE_xcEs+AWgOg5531BLuQ@mail.gmail.com>
References: <20200918132439.1475479-1-arnd@arndb.de> <20200918132439.1475479-2-arnd@arndb.de> <20200919053514.GI30063@infradead.org> <CALCETrVDqHG2chDsLWBHF39SXh6vjzE_xcEs+AWgOg5531BLuQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH 1/4] x86: add __X32_COND_SYSCALL() macro
To:     Andy Lutomirski <luto@kernel.org>,
        Christoph Hellwig <hch@infradead.org>
CC:     Arnd Bergmann <arnd@arndb.de>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Eric Biederman <ebiederm@xmission.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-arch <linux-arch@vger.kernel.org>,
        Linux-MM <linux-mm@kvack.org>, kexec@lists.infradead.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
        Christoph Hellwig <hch@lst.de>, Brian Gerst <brgerst@gmail.com>
From:   hpa@zytor.com
Message-ID: <85F32523-4E9E-443A-A150-10A9E5EB0CE3@zytor.com>
Precedence: bulk

On September 19, 2020 9:23:22 AM PDT, Andy Lutomirski <luto@kernel=2Eorg> w=
rote:
>On Fri, Sep 18, 2020 at 10:35 PM Christoph Hellwig <hch@infradead=2Eorg>
>wrote:
>>
>> On Fri, Sep 18, 2020 at 03:24:36PM +0200, Arnd Bergmann wrote:
>> > sys_move_pages() is an optional syscall, and once we remove
>> > the compat version of it in favor of the native one with an
>> > in_compat_syscall() check, the x32 syscall table refers to
>> > a __x32_sys_move_pages symbol that may not exist when the
>> > syscall is disabled=2E
>> >
>> > Change the COND_SYSCALL() definition on x86 to also include
>> > the redirection for x32=2E
>> >
>> > Signed-off-by: Arnd Bergmann <arnd@arndb=2Ede>
>>
>> Adding the x86 maintainers and Brian Gerst=2E  Brian proposed another
>> problem to the mess that most of the compat syscall handlers used by
>> x32 here:
>>
>>    https://lkml=2Eorg/lkml/2020/6/16/664
>>
>> hpa didn't particularly like it, but with your and my pending series
>> we'll soon use more native than compat syscalls for x32, so something
>> will need to change=2E=2E
>
>I'm fine with either solution=2E

My main objection was naming=2E x64 is a widely used synonym for x86-64, a=
nd so that is confusing=2E

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E