Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751194AbWHBPYP (ORCPT ); Wed, 2 Aug 2006 11:24:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751195AbWHBPYP (ORCPT ); Wed, 2 Aug 2006 11:24:15 -0400 Received: from mail.CS.McGill.CA ([132.206.51.234]:17939 "EHLO mail.cs.mcgill.ca") by vger.kernel.org with ESMTP id S1751194AbWHBPYO (ORCPT ); Wed, 2 Aug 2006 11:24:14 -0400 Message-ID: <44D0C39D.7040408@cs.ubishops.ca> Date: Wed, 02 Aug 2006 11:24:13 -0400 From: Patrick McLean User-Agent: Thunderbird 1.5.0.5 (X11/20060729) MIME-Version: 1.0 To: Dave Jones , Andreas Schwab , Alexey Dobriyan , Alan Cox , Linux Kernel Subject: Re: single bit flip detector. References: <20060801184451.GP22240@redhat.com> <1154470467.15540.88.camel@localhost.localdomain> <20060801223011.GF22240@redhat.com> <20060801223622.GG22240@redhat.com> <20060801230003.GB14863@martell.zuzino.mipt.ru> <20060801231603.GA5738@redhat.com> <20060801235109.GB12102@redhat.com> <20060802001626.GA14689@redhat.com> In-Reply-To: <20060802001626.GA14689@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1598 Lines: 42 Dave Jones wrote: > On Tue, Aug 01, 2006 at 07:51:09PM -0400, Dave Jones wrote: > > I'm going for the record of 'most times a patch gets submitted in one day'. > > And to think we were complaining that patches don't get enough review ? :) > > If every change had this much polish, we'd be awesome. > > Sigh. Spaces before printk. Whatever next. > I am now officially bored of seeing this patch. > > Dave > > > In case where we detect a single bit has been flipped, we spew > the usual slab corruption message, which users instantly think > is a kernel bug. In a lot of cases, single bit errors are > down to bad memory, or other hardware failure. > > This patch adds an extra line to the slab debug messages > in those cases, in the hope that users will try memtest before > they report a bug. > > 000: 6b 6b 6b 6b 6a 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b > Single bit error detected. Possibly bad RAM. Run memtest86. > > Signed-off-by: Dave Jones > > + if (errors && !(errors & (errors-1))) { > + printk(KERN_ERR "Single bit error detected. Probably bad RAM.\n"); > +#ifdef CONFIG_X86 #if defined(CONFIG_X86) || defined(CONFIG_X86_64) memtest86+ runs fine on x86_64 machines as well. > + printk(KERN_ERR "Run memtest86+ or a similar memory test tool.\n"); > +#else > + printk(KERN_ERR "Run a memory test tool.\n"); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/