Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2464887pxk; Sun, 20 Sep 2020 05:11:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwq8vsKB3+hH+/3yTmY/EObba/Ln8iUVba01N3sQ3YYDLlvfIRJMWpn8wsxhobhetkypBzp X-Received: by 2002:a17:906:b156:: with SMTP id bt22mr44392357ejb.481.1600603866273; Sun, 20 Sep 2020 05:11:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600603866; cv=none; d=google.com; s=arc-20160816; b=BkBDCQowzzinoviOoGPOOmfkr8BTVsaOqDfM1KP6G8znBtRqed3cKJQ67cEK3Rj8Pk OtcOfqJFpFo9wJAm+deZwsgqZ9oexDi6kaOGDkYNnGaxNsZesYUFS0j6+ZRd2yIlwafO /RbF5R9yQXHGuBAq7l5ovHw9OlkWVl3Ir2QkpDTkmPB4mPlgHS8VdFvkxf9cjofWdO1k HJSCn/ZfjyWFil2Xoqxccc9D47Z+VD//xqtBWmBoYuYyaFR9rpeAkTGnBCKG3BdLV5NO +Vnk7Gx5EkYyzty23WnmrfCCr2F2OEmEshaFORgU4a9EQPamRL/vy/OLLiqWGvsQNxa9 vzqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=VBE98+XviGbhkkXJFYQmbfxF1dXBbrg7L9EVTmatlu8=; b=NZsJ1PpzFP9iN5pf11QSS4pwjtbJx9ToSyWgm+kY77+KJeO3mjQTOVQHE6xyB5rBoh Whol+0fTuC0FdcAG+pAFNNfFN2ayv0v1HuOVBVCQ676xuFXf3jGLImFiQRlFACRckSdj wo+t7DLQbTgKRwv1XVSUrxA8/92Rl+5k6NK/6pw/by1+h7Y2XGfPIc1mfXoabPXyVR44 zhwuoCAOO0RgoGcbV+XbggMIb6loqyQpumRBKTIM1vLbEEQawT6L/nSCivVP3v12N2OH oqf0ULT97SNo842aOsnTQioPQsljH9aLscpyNGOe86AjudEGsZS8RKImGZbvipJsi+pg 8yeA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e14si6568943edm.126.2020.09.20.05.10.35; Sun, 20 Sep 2020 05:11:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726496AbgITMJ2 (ORCPT + 99 others); Sun, 20 Sep 2020 08:09:28 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:50059 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726401AbgITMJP (ORCPT ); Sun, 20 Sep 2020 08:09:15 -0400 X-IronPort-AV: E=Sophos;i="5.77,282,1596492000"; d="scan'208";a="468612192" Received: from palace.lip6.fr ([132.227.105.202]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES256-SHA256; 20 Sep 2020 14:08:58 +0200 From: Julia Lawall To: Jens Axboe Cc: kernel-janitors@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/14] block: drop double zeroing Date: Sun, 20 Sep 2020 13:26:18 +0200 Message-Id: <1600601186-7420-7-git-send-email-Julia.Lawall@inria.fr> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1600601186-7420-1-git-send-email-Julia.Lawall@inria.fr> References: <1600601186-7420-1-git-send-email-Julia.Lawall@inria.fr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sg_init_table zeroes its first argument, so the allocation of that argument doesn't have to. the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; @@ x = - kzalloc + kmalloc (...) ... sg_init_table(x,...) // Signed-off-by: Julia Lawall --- block/bsg-lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/block/bsg-lib.c b/block/bsg-lib.c --- a/block/bsg-lib.c +++ b/block/bsg-lib.c @@ -207,7 +207,7 @@ static int bsg_map_buffer(struct bsg_buf BUG_ON(!req->nr_phys_segments); - buf->sg_list = kzalloc(sz, GFP_KERNEL); + buf->sg_list = kmalloc(sz, GFP_KERNEL); if (!buf->sg_list) return -ENOMEM; sg_init_table(buf->sg_list, req->nr_phys_segments);