Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2464886pxk;
        Sun, 20 Sep 2020 05:11:06 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzZmy+uOjx+72E+Cw556yDi9zJI5ma5Qia8s1iI1fIHIRdDvn4fWUiMpcnIG6YbwzeyvlyA
X-Received: by 2002:a17:906:d7a2:: with SMTP id pk2mr44424869ejb.149.1600603866282;
        Sun, 20 Sep 2020 05:11:06 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1600603866; cv=none;
        d=google.com; s=arc-20160816;
        b=gF2BS54Gi6RuX1mnD2LGhNCTti8HayirFzm49qVjH0UYGrfIu9HCyYs9s3EduF+XkJ
         UQnPZ6Gqwh4Cb0KFtHm9IZJTP1LjrPhJV5NHzvptFqJJ1IZPMaWZs0VMXdmx0oHPB/2L
         7zTL0/QkT88EohPZdHG2IICtvazI9Kw1pfbQwHxuFbQiyAOGIzU2d8ANRLIIYTephJUa
         0RIhjyHnGHHezu+a3aqPiXD7lyQFMICIM08lVj29pxfs7/9UNzlqCzhicdCTeYUydQZc
         g7gp0m7KBKF00HUCFGv6xEVsviDLGvTu/jotrflYAUhapKbt429hq02RIEAGZLXP2aBn
         FCmQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:references:in-reply-to:message-id:date:subject
         :cc:to:from;
        bh=admm8oSN8vBDLZ3no0Vmfo5Ijp45rQaifd4/imepZYw=;
        b=PSIpbmpXD1yz1yUp7FgwlBPsMnOWTzSRMEbV+3FQKhLzV7KY41tXILDL9na1OHZ0Um
         fB3iHoSJD5dTRwMSs0j88glXkOBbRYuCU2WJeZepAAZs3xRe1zaz2FyJdvRmo5HoQFdE
         qA5fZZRGd/zQsztUpB3/AxX5nM7uKddaFdMM3WZQrxPf1YsO6AoPKb6ivZV5aiVyoCtO
         wFbknJ2jTgP3EV8QhzLUjkT4PIMKBvYJyTDDECSo4TR1ZnhgMkI/zneuNN03PVWgfRdY
         dyZCoN1tSzHpNjkgPa7tU872RIw3hy2+mAFS85E9oC36SAIRlx9UsAz51HVvRQTM6TdT
         AQ8g==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id y11si6282473edm.191.2020.09.20.05.10.28;
        Sun, 20 Sep 2020 05:11:06 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726333AbgITMJJ (ORCPT <rfc822;arandomawesomegeek@gmail.com>
        + 99 others); Sun, 20 Sep 2020 08:09:09 -0400
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:50034 "EHLO
        mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1726273AbgITMJJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 20 Sep 2020 08:09:09 -0400
X-IronPort-AV: E=Sophos;i="5.77,282,1596492000"; 
   d="scan'208";a="468612189"
Received: from palace.lip6.fr ([132.227.105.202])
  by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES256-SHA256; 20 Sep 2020 14:08:58 +0200
From:   Julia Lawall <Julia.Lawall@inria.fr>
To:     Ioana Ciornei <ioana.ciornei@nxp.com>
Cc:     kernel-janitors@vger.kernel.org,
        Ioana Radulescu <ruxandra.radulescu@nxp.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH 03/14] dpaa2-eth: drop double zeroing
Date:   Sun, 20 Sep 2020 13:26:15 +0200
Message-Id: <1600601186-7420-4-git-send-email-Julia.Lawall@inria.fr>
X-Mailer: git-send-email 1.9.1
In-Reply-To: <1600601186-7420-1-git-send-email-Julia.Lawall@inria.fr>
References: <1600601186-7420-1-git-send-email-Julia.Lawall@inria.fr>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

sg_init_table zeroes its first argument, so the allocation of that argument
doesn't have to.

the semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x,n,flags;
@@

x = 
- kcalloc
+ kmalloc_array
  (n,sizeof(struct scatterlist),flags)
...
sg_init_table(x,n)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

---
 drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -u -p a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
@@ -607,7 +607,7 @@ static int dpaa2_eth_build_sg_fd(struct
 	if (unlikely(PAGE_SIZE / sizeof(struct scatterlist) < nr_frags + 1))
 		return -EINVAL;
 
-	scl = kcalloc(nr_frags + 1, sizeof(struct scatterlist), GFP_ATOMIC);
+	scl = kmalloc_array(nr_frags + 1, sizeof(struct scatterlist), GFP_ATOMIC);
 	if (unlikely(!scl))
 		return -ENOMEM;