Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2464969pxk; Sun, 20 Sep 2020 05:11:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxA8yl/R0DAIAZ3mIbtWZyBIaBNyiMuAXtiaRjthg0aBBl+J1behYBywJjHxO83FxYt8rAF X-Received: by 2002:a17:906:7fcb:: with SMTP id r11mr43403093ejs.519.1600603875932; Sun, 20 Sep 2020 05:11:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600603875; cv=none; d=google.com; s=arc-20160816; b=nPUChGL73o1gOlt+GmGwl9DcjoPTws6uW4/SCxb36jYzUkDkLHReswfKIrbSEjLZk0 ic8cpLqlS+pm/LzS/oABdZCW3EmUb4O6F0A0A4ODltYxHbZto1L/cyaHTEioIAmIfXwv UJIND1GzBzJIYInt8RoanM8SZV2PYGgVgB73D2s0KgRkMkSzZ6sck2JnZPQrGzwL3T9v nTQGh5pRfVdNDsmEouG0Dp3Jrjd6ITdbu1jI98Y1a/ML4KGNPtLIGaJnauKdgmdQ5RW+ WxUYc/xWqb/phaauKcdkR0JvwxcKV+ll876kf2L5jbYhft+yxjdWuamqbwTflAvidtmk ew7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=VHAElLzDJ27LJ/fgqk+QNrF1aG9xBdzzaGMoeSbXyYY=; b=pt9QgIk5MsoxluHZK0tE/IOhJv5cU5QRocfJctjdCT+D5FQsYrhkwcVfe2kcqNJIwd 8yNOW7+c9pFAgwn9xe92XLOKDHXJ8Pcd9adjeV/t+UlxWA6wHQVVwHTcP8kHmqZ6pPYV sTnjC1Qj76zhgUAnnAXXuTWFCZiAPWYy3oBFAZc5w0swgk8BlXYLwn+80BLnsSxm4xcy gL7J+gtZoAplXcfkcEatKLhtK8dse8dKnFf7YNHBAnT0BGCys1mhOlpjqgudx0sqYjQg iqqontKhLIGRWdwDU1K5/wrCT64xaJr1QCL856nT4rIwyBkA7DRLxleJKvudtfFb9b6L flSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n20si6316770eda.406.2020.09.20.05.10.53; Sun, 20 Sep 2020 05:11:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726545AbgITMJd (ORCPT + 99 others); Sun, 20 Sep 2020 08:09:33 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:50064 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726445AbgITMJY (ORCPT ); Sun, 20 Sep 2020 08:09:24 -0400 X-IronPort-AV: E=Sophos;i="5.77,282,1596492000"; d="scan'208";a="468612198" Received: from palace.lip6.fr ([132.227.105.202]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES256-SHA256; 20 Sep 2020 14:08:58 +0200 From: Julia Lawall To: Hans Verkuil Cc: kernel-janitors@vger.kernel.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/14] [media] saa7146: drop double zeroing Date: Sun, 20 Sep 2020 13:26:24 +0200 Message-Id: <1600601186-7420-13-git-send-email-Julia.Lawall@inria.fr> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1600601186-7420-1-git-send-email-Julia.Lawall@inria.fr> References: <1600601186-7420-1-git-send-email-Julia.Lawall@inria.fr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sg_init_table zeroes its first argument, so the allocation of that argument doesn't have to. the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,n,flags; @@ x = - kcalloc + kmalloc_array (n,sizeof(struct scatterlist),flags) ... sg_init_table(x,n) // Signed-off-by: Julia Lawall --- drivers/media/common/saa7146/saa7146_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/drivers/media/common/saa7146/saa7146_core.c b/drivers/media/common/saa7146/saa7146_core.c --- a/drivers/media/common/saa7146/saa7146_core.c +++ b/drivers/media/common/saa7146/saa7146_core.c @@ -140,7 +140,7 @@ static struct scatterlist* vmalloc_to_sg struct page *pg; int i; - sglist = kcalloc(nr_pages, sizeof(struct scatterlist), GFP_KERNEL); + sglist = kmalloc_array(nr_pages, sizeof(struct scatterlist), GFP_KERNEL); if (NULL == sglist) return NULL; sg_init_table(sglist, nr_pages);