Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2465424pxk; Sun, 20 Sep 2020 05:12:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzuXb6aXd19uOe9U8ILqUect/xHX7QHjLDai0Fa56oGNasjTfM+xuSNaJYTdc/0BBmmUaPq X-Received: by 2002:a05:6402:209:: with SMTP id t9mr49653322edv.208.1600603939236; Sun, 20 Sep 2020 05:12:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600603939; cv=none; d=google.com; s=arc-20160816; b=XI8jX9wuKRzfSIYrpV0JBC/Xfjolc+rPSMIZGO6j6NJrRcMLfH1DHuGC2mLSjMKXoG 7COjNeZuKcv1Bm5+IzsPvYzWtG8pCU7aVooEaRC00EEsIH2s63gGqf+0JZMpftL5lfrH QvjhfbYYEXB0V+M9dHjMMEdc/kI3vKNc1syUDbSM7jeKcFHvjyFwG+0xWXDHOy5oY7L+ k/KQjAuSiCtNj4oU/POGQTO/X5Zg6SJmuj1bkB5/OVz3YFDP/922Y91+X9BbwYFHUV+8 fSAGEMHOcrE47oSz7fu9Bq0vrvnTmJPQ7AuTFbgkJRN3DH9PMXQyBlAWTXBLcFFFArdu E8cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=DaIL2odRPr/T8gnAhXd9tuDbaXZ4omNbfF2yc1Mea+0=; b=TRWqhzvSfi+0NY1LesX/luLImybX95ZxuaLAAZ1H1NPbWE1elXSLlsBfElm78QVq8/ xC+0STaOE1f+Ir8No5E6a6WBCzImB+sz+J1SWbEeMiByct9SRLshMRHp9JmUesFLLBhg BJJl0UM5wXCcLLLlDTOT7EF3ZvIpPp6H2xyzrDAH9dDlnXmrYhJlKx47zGDlTeOSbGER tpJ0CaoWq91bu1aQzWPJBfZC/v4dZ5T0qBCZlNwPD2gfYYDuoEIRYeV//bLSKkX9+MOd yTboOXp0lDJgvWK53bWIXG+2pVlWwNI5rnm9+YHeUQbUD1F0MfIbBXd/mLg57WA7Guwo 4ufw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bl4si7147152ejb.752.2020.09.20.05.11.56; Sun, 20 Sep 2020 05:12:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726591AbgITMJt (ORCPT + 99 others); Sun, 20 Sep 2020 08:09:49 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:50064 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726485AbgITMJb (ORCPT ); Sun, 20 Sep 2020 08:09:31 -0400 X-IronPort-AV: E=Sophos;i="5.77,282,1596492000"; d="scan'208";a="468612194" Received: from palace.lip6.fr ([132.227.105.202]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES256-SHA256; 20 Sep 2020 14:08:58 +0200 From: Julia Lawall To: "J. Bruce Fields" Cc: kernel-janitors@vger.kernel.org, Chuck Lever , Trond Myklebust , Anna Schumaker , "David S. Miller" , Jakub Kicinski , linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/14] xprtrdma: drop double zeroing Date: Sun, 20 Sep 2020 13:26:20 +0200 Message-Id: <1600601186-7420-9-git-send-email-Julia.Lawall@inria.fr> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1600601186-7420-1-git-send-email-Julia.Lawall@inria.fr> References: <1600601186-7420-1-git-send-email-Julia.Lawall@inria.fr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sg_init_table zeroes its first argument, so the allocation of that argument doesn't have to. the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,n,flags; @@ x = - kcalloc + kmalloc_array (n,sizeof(*x),flags) ... sg_init_table(x,n) // Signed-off-by: Julia Lawall --- net/sunrpc/xprtrdma/frwr_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/net/sunrpc/xprtrdma/frwr_ops.c b/net/sunrpc/xprtrdma/frwr_ops.c --- a/net/sunrpc/xprtrdma/frwr_ops.c +++ b/net/sunrpc/xprtrdma/frwr_ops.c @@ -124,7 +124,7 @@ int frwr_mr_init(struct rpcrdma_xprt *r_ if (IS_ERR(frmr)) goto out_mr_err; - sg = kcalloc(depth, sizeof(*sg), GFP_NOFS); + sg = kmalloc_array(depth, sizeof(*sg), GFP_NOFS); if (!sg) goto out_list_err;