Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2466063pxk; Sun, 20 Sep 2020 05:13:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyWwe0KC4goyLOQ4Nclm+bCZDnPXekZZxRU52ebY/GgU0+fdRPK91kN9OEogmlmjdNYtqQh X-Received: by 2002:a17:906:46c9:: with SMTP id k9mr43835370ejs.38.1600604018181; Sun, 20 Sep 2020 05:13:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600604018; cv=none; d=google.com; s=arc-20160816; b=phm4hOIgahGDWL/1yn2MWGGPHSSnCBJ4hBr3nSDWGLjvkMylY3rDM+nQDCRmgZEk5I zrtpKkbmbrV1bkmgNgIiYpRCeNjq+RL3rEqPA/uVubwvIu8HSBV+fMFkxV/ttUBa4jRd EfFMKmdB2Zsvw2YldwOU61DSJT4JCarcJ6ThZzOxXukW7YlLWqzW+bNE0jb3Q4m9xXpZ YPQvepUIde7jaYcDS3IdGjUG1eJ/+aqTDyY7Nar7GAHFNNZSO0u+ya27I60Wx3CH0fAW Ig9AJdrDKJGawGunRsBoQotoYPBs3ODfClMP1wlKyRYmdcqsxTrjfKfe7zq0bpCpdiOo RSZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=ktdlh4cl+nELkqa+1/gHwl8/5aqdRSkhNOgOmkbMKIc=; b=zlVzNYGAoThIcxmBOmrn6xh3dXu+AweFwmgdeFibCHgjOsMLTBKHGnwdkMBI7zsJ+X tN61rcNQjw8iS9iw62c/5JrJ8RUA99sB3MX+E84S+EKLuqbDk7zFssK/KLDDf9TetuFj uMqswoDJ1kbL5gTEjEYDpN1YzcNErGN6nFCe1pLkg936eAskTy7gZ0iNFNJ7hZcyBnuM bMEyr6k1wO90FWFHYppyxO168hxPsBDRjDbagtlwxIOfa2BySSMEoTDp4Y+5utwDkMBI L1Yuu+sWLS58pvwKiuQLYc51f9SpZlW2kzBRF4+TeJTzbiXefdrE9KaFDCGWOXzuqZ8g v2+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d25si6066837edy.405.2020.09.20.05.13.15; Sun, 20 Sep 2020 05:13:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726382AbgITMJL (ORCPT + 99 others); Sun, 20 Sep 2020 08:09:11 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:50059 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726273AbgITMJL (ORCPT ); Sun, 20 Sep 2020 08:09:11 -0400 X-IronPort-AV: E=Sophos;i="5.77,282,1596492000"; d="scan'208";a="468612188" Received: from palace.lip6.fr ([132.227.105.202]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES256-SHA256; 20 Sep 2020 14:08:58 +0200 From: Julia Lawall To: "Martin K. Petersen" Cc: kernel-janitors@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/14] target/rd: drop double zeroing Date: Sun, 20 Sep 2020 13:26:14 +0200 Message-Id: <1600601186-7420-3-git-send-email-Julia.Lawall@inria.fr> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1600601186-7420-1-git-send-email-Julia.Lawall@inria.fr> References: <1600601186-7420-1-git-send-email-Julia.Lawall@inria.fr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sg_init_table zeroes its first argument, so the allocation of that argument doesn't have to. the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,n,flags; @@ x = - kcalloc + kmalloc_array (n,sizeof(*x),flags) ... sg_init_table(x,n) // Signed-off-by: Julia Lawall --- drivers/target/target_core_rd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/drivers/target/target_core_rd.c b/drivers/target/target_core_rd.c --- a/drivers/target/target_core_rd.c +++ b/drivers/target/target_core_rd.c @@ -131,7 +131,7 @@ static int rd_allocate_sgl_table(struct if (sg_per_table < total_sg_needed) chain_entry = 1; - sg = kcalloc(sg_per_table + chain_entry, sizeof(*sg), + sg = kmalloc_array(sg_per_table + chain_entry, sizeof(*sg), GFP_KERNEL); if (!sg) return -ENOMEM;