Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2466151pxk; Sun, 20 Sep 2020 05:13:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyp6J3/OctRF7Nqc9GqlhnyBPTBx77UPAD88tZicBvo1UWhq160bQeBlt1sHtpA5Pm03BPQ X-Received: by 2002:a17:906:a45a:: with SMTP id cb26mr30097371ejb.387.1600604028436; Sun, 20 Sep 2020 05:13:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600604028; cv=none; d=google.com; s=arc-20160816; b=u0vfllqo2hrXGJj4Md5hHzDh5B7O40SJQgkxdyfwnIzh3R6XCkFYqc3v8RI8LINYjq CTOoFzJ1MthYIEOq3NIcM/NsVuNv1qeXG4THsJMTZBQOalXhQqJWjO4xk/xHGeIBNKit lS12XroZ9j/zp4f5N+bMI3nq+wNqBi3RlVazT+AM145HEeukoxu7GHRWbHzO4R3vr6M/ YXbzZ7kYuLGu5jAK3n28QtpUsU5yHfa+eTsyP7F2Va6yXYxNS7g5mroW7KYMW1in/Ylw vFwR2gIdA+dE31mk+S952GYRToqsrvdYYMHbSU1mKVYthU3wvHqbMDgtfIw4GVzeTccy nzpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=nW59dSvTQXR0h4tPCi0u0y3oAofVuid944DqfkHOJ3E=; b=0ZE/m4KaCOzSzr0fn1b2r+c7dhKkvj4lvwgzReOfab1xpOd65NStnk3B9Tg2QSr2Rx 3c6E1CHmHnkMxeP8mkJKqIcfUANvNNQKCaYnpdQk4oA0zrJ0UPD3POkD4Ok7TNifnTh0 pzyJz2g1No4spW5timlrJOXxuEhNJiwTY++ENobpskZ0KglWe5s/S5eEstthl5JqEMnI HXKBI4RHZ+PH+hh7gs7m/T4cw01Gsw6uY9TCNwMg/8NczHfT/GaAwqqvWbruValW37SY eHjfQgBD/Gfg8pIDPHOW4qtDD7mvZphC13rGhumoGk8bu3dmwn3Fw8H9a+ad1v/ppbSa LePQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bq23si6259514ejb.116.2020.09.20.05.13.25; Sun, 20 Sep 2020 05:13:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726613AbgITMJ4 (ORCPT + 99 others); Sun, 20 Sep 2020 08:09:56 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:50059 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726444AbgITMJY (ORCPT ); Sun, 20 Sep 2020 08:09:24 -0400 X-IronPort-AV: E=Sophos;i="5.77,282,1596492000"; d="scan'208";a="468612195" Received: from palace.lip6.fr ([132.227.105.202]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES256-SHA256; 20 Sep 2020 14:08:58 +0200 From: Julia Lawall To: Vinod Koul Cc: kernel-janitors@vger.kernel.org, Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/14] dmaengine: rcar-dmac: drop double zeroing Date: Sun, 20 Sep 2020 13:26:21 +0200 Message-Id: <1600601186-7420-10-git-send-email-Julia.Lawall@inria.fr> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1600601186-7420-1-git-send-email-Julia.Lawall@inria.fr> References: <1600601186-7420-1-git-send-email-Julia.Lawall@inria.fr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sg_init_table zeroes its first argument, so the allocation of that argument doesn't have to. the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,n,flags; @@ x = - kcalloc + kmalloc_array (n,sizeof(*x),flags) ... sg_init_table(x,n) // Signed-off-by: Julia Lawall --- drivers/dma/sh/rcar-dmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c --- a/drivers/dma/sh/rcar-dmac.c +++ b/drivers/dma/sh/rcar-dmac.c @@ -1227,7 +1227,7 @@ rcar_dmac_prep_dma_cyclic(struct dma_cha * Allocate the sg list dynamically as it would consume too much stack * space. */ - sgl = kcalloc(sg_len, sizeof(*sgl), GFP_NOWAIT); + sgl = kmalloc_array(sg_len, sizeof(*sgl), GFP_NOWAIT); if (!sgl) return NULL;