Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2648272pxk; Sun, 20 Sep 2020 11:40:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOwdg2ZDw9I/UFKbe12sfnC4oHPkHBMaIi6xJpcksi1DHeFkRmUM35qaMJqz6YG0k2+Q0J X-Received: by 2002:a17:906:2985:: with SMTP id x5mr45583475eje.136.1600627205612; Sun, 20 Sep 2020 11:40:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600627205; cv=none; d=google.com; s=arc-20160816; b=lmElo4w4fJBJWBTpMctXNAYaTgMtBFiL0LwWPaSJYeHFOA4+XUAYKVdMuCyu7QuWqc OUzpSEzktZTeBlwLqNCN6vf6EmN62/0FvsmhvYVuOIofJThlBgUpKpN5BZMsL/xVkSDT TU2EnyjM4h1L1aJsWSB70ESHLLtf/N3IotZ+3AKyg89sDCZ7HnZpgpt1z+9pUUZJiT+G QjDqDWFumYlGNbVm0+geMcUaDlgm+ewkhj1SloNtFMTd2iLaAajA6dzFx1Rez0PYeYym FqqFOU9Hsnk+oD2m754ZMf4qOEBHHFUGAP/srrNJBYCjL70xR0KmqFE1OAHgJXdSPmDm zulw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=Gd2hvr/SAKzjKtmSl3X2mEioPmDAlGeI7zVBmc2l4K8=; b=H4ZjYPAEUiRlKdLqtABW52N1d1wCo6JCg4wsZ+Cf3JcjlwtFHS73Gwho1GJKQREOw/ SausnFw2X/NnX7V1VC4/IvkdwIWOjb5v9SQKSZOVgNpfvM2qxvzclZJgbVA7e3t5+toT q2J8gqNhYoDU6nnUbhU1Vc0oOK4/dvsWxOajCxWjzdkXbYN5HgCzRptWhcWfLcMtfL05 ARjKTOEGKV2SJkmfnfeEMRGczP1+joFmFYloxFBhLATclwSOdo+CwMbyEsnXfTeYzm9i j8zDiHMa78vXGTY0txQBjyc8Ss5Ih+EY38uZDC/OMaIlcIVtft68N0rabWBxaI0ZYigS Qt5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=cxfwt+vj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a21si6432722eds.368.2020.09.20.11.39.42; Sun, 20 Sep 2020 11:40:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=cxfwt+vj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726353AbgITShs (ORCPT + 99 others); Sun, 20 Sep 2020 14:37:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726183AbgITShc (ORCPT ); Sun, 20 Sep 2020 14:37:32 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93F68C0613D5 for ; Sun, 20 Sep 2020 11:37:29 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id x23so9993539wmi.3 for ; Sun, 20 Sep 2020 11:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Gd2hvr/SAKzjKtmSl3X2mEioPmDAlGeI7zVBmc2l4K8=; b=cxfwt+vj0IMFYW+JQ/I7RatzPtFw1+jGLORAJybIyLwiBbd8P6wU5H00s9S1g4XMCY UtVX46Nx5geEh0rX6GT/R1NqCO0wAXNvq3PTMp5xIYww5KxBWgMxCm08fYTjWz8EDRly ORI6B+JW2+/ifJ9LxD6u6F21uUfuTr3CMQTPHbky+JTF7baBn+u9aYHI31U0DUYBtoPK Gku7/dytrVz3juRK5t7OQNxRwpCr840JqSDM2TwYFdt0VxmmGUHG41RSjfnRWNaCOPDB T0dou1BYOe5x7NuYgGSLZ8uaOHyw0lvLaQmG7zhUGOm7By0kKCa6jx/62Q5Gu59Csz3q Mhag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Gd2hvr/SAKzjKtmSl3X2mEioPmDAlGeI7zVBmc2l4K8=; b=XgC3T+9Job+rcUPWMJhDmxmQt6o7sETJasUQmXFLEdyA6Cu+WrXqgx2XZIGQ6fK09Q 48sOldBYhpUh1QWwc1vQ3NT0GtbTqZfwLJTulTBFR8GTAG4jUf7NvKqpgO1z7gBOHFQt b7J/N2fsaQPoKVX98GlGRHhAtobtgmGqi3Y1r1MkqKAWJajD1kBx0TLMETpTz1mcSCYF Yii57Le/U2AJ9gYqXFvjJoLcH0Ye55Ag9AtFyrLo4KakDu9FIutQoKJG/Z9iR39RpOHj sAcdq+XdmJn7+oClWPWzM4Uqe7quUxzmRsFu/qcRfz1/jIaSMXo11tKFEzHgtAORqxDr z0uQ== X-Gm-Message-State: AOAM5325mefyx+jLgWFJD/RWXmA8hXts4VxR5+030R6pAIguEMj7lt+R i3RTevY1P/QmrEB+NrveTAEZoA== X-Received: by 2002:a1c:f208:: with SMTP id s8mr27172664wmc.85.1600627048332; Sun, 20 Sep 2020 11:37:28 -0700 (PDT) Received: from localhost.localdomain ([51.15.160.169]) by smtp.googlemail.com with ESMTPSA id e18sm16419841wrx.50.2020.09.20.11.37.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Sep 2020 11:37:27 -0700 (PDT) From: Corentin Labbe To: arnd@arndb.de, davem@davemloft.net, herbert@gondor.apana.org.au, mripard@kernel.org, wens@csie.org Cc: linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Corentin Labbe , stable@vger.kernel.org Subject: [PATCH v2 4/7] crypto: sun4i-ss: handle BigEndian for cipher Date: Sun, 20 Sep 2020 18:37:15 +0000 Message-Id: <1600627038-40000-5-git-send-email-clabbe@baylibre.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1600627038-40000-1-git-send-email-clabbe@baylibre.com> References: <1600627038-40000-1-git-send-email-clabbe@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ciphers produce invalid results on BE. Key and IV need to be written in LE. Fixes: 6298e948215f2 ("crypto: sunxi-ss - Add Allwinner Security System crypto accelerator") Cc: Signed-off-by: Corentin Labbe --- drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c index c6c25204780d..a05889745097 100644 --- a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c +++ b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c @@ -52,13 +52,13 @@ static int noinline_for_stack sun4i_ss_opti_poll(struct skcipher_request *areq) spin_lock_irqsave(&ss->slock, flags); - for (i = 0; i < op->keylen; i += 4) - writel(*(op->key + i / 4), ss->base + SS_KEY0 + i); + for (i = 0; i < op->keylen / 4; i++) + writel(cpu_to_le32(op->key[i]), ss->base + SS_KEY0 + i * 4); if (areq->iv) { for (i = 0; i < 4 && i < ivsize / 4; i++) { v = *(u32 *)(areq->iv + i * 4); - writel(v, ss->base + SS_IV0 + i * 4); + writel(cpu_to_le32(v), ss->base + SS_IV0 + i * 4); } } writel(mode, ss->base + SS_CTL); @@ -225,13 +225,13 @@ static int sun4i_ss_cipher_poll(struct skcipher_request *areq) spin_lock_irqsave(&ss->slock, flags); - for (i = 0; i < op->keylen; i += 4) - writel(*(op->key + i / 4), ss->base + SS_KEY0 + i); + for (i = 0; i < op->keylen / 4; i++) + writel(cpu_to_le32(op->key[i]), ss->base + SS_KEY0 + i * 4); if (areq->iv) { for (i = 0; i < 4 && i < ivsize / 4; i++) { v = *(u32 *)(areq->iv + i * 4); - writel(v, ss->base + SS_IV0 + i * 4); + writel(cpu_to_le32(v), ss->base + SS_IV0 + i * 4); } } writel(mode, ss->base + SS_CTL); -- 2.26.2