Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2663768pxk; Sun, 20 Sep 2020 12:16:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBTkdhvP7ZxSsKDIyBWkSjKJaEqvvRStdV04EzrvIa72ic/O9BQ16IvoxUkdvRavPCHVAM X-Received: by 2002:aa7:c347:: with SMTP id j7mr50813176edr.185.1600629387534; Sun, 20 Sep 2020 12:16:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600629387; cv=none; d=google.com; s=arc-20160816; b=jFCMhoACvy+XcNsAN1tk4xDGDvvIrau5Ur6DgAjaNIb0X7JSmL0GEr3SClJLL/6hGg XOt2k9Tp2rSYUfZtIQ+CacHhIJUbzb5q4ZPqRUnr09kvoPmZRTdVdffg+KdtzgsekwFl aniJ3TqMCsmdKzHJA3yB0cv3BcEmSWF47RFGcS6CSDFx06KnJTyaTIwj7SktaGfYpGpc J6srMmFuf+WD2QidoF//HTWYDDxLsXKqkEUj+vWkD0g4zgmi59bJZQhFK22EQ3AgbwJq g/nmBQkD/IyuDy7ZlW5yOW/IagijaIkmrvIxyVDZz4Y8gMoY2bIxqmwdQ8bAoXr653np GNHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=Zci4MIKsez3eEXBbvQ9RT4B101N7BY9nq8x/RTzAtWc=; b=HIiFmgxMHILLQk0jLBiVgNxlF8TFz5gpmgG4xmNoVG8G36nVuLmVgiRqwaUELbjkHN MjIuZA3N6MjrISKmg4zhrZSACmbk/kJWxmOKxvCut1FiCrOad2n3uL2Zo9bfjqoH1eVa B2WrCFq3e0FU89fkNRezpRA/2oeDi1uJzXiZT+q2D8uYXZsImv8AU1b0+Ev72+Fia0tg DgEJhl4V75DFE3UAzLS9GrcSt+fEvt17/9l8J20zTWxUYh37u9/uGEJxDcLfRtUCEJA9 pYPQFBWn73ETAyMzc6Jb8bDVekFjZ0vU5u4gyU54rBuIx1t5K3v3939MDexXJIRbEv27 phTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PjyDniQs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e1si6872832edy.163.2020.09.20.12.16.03; Sun, 20 Sep 2020 12:16:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PjyDniQs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726303AbgITTPD (ORCPT + 99 others); Sun, 20 Sep 2020 15:15:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:60066 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726109AbgITTPD (ORCPT ); Sun, 20 Sep 2020 15:15:03 -0400 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F416207D3 for ; Sun, 20 Sep 2020 19:15:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600629302; bh=01MigO53P6iyZydtBYB0dVEV2Jvv4nS2ce79nd2bE4Q=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=PjyDniQs3KsBKfILCo6DAkzBMbsRqEcz0eTgRBTcYSLWjku25BIq5mD1QmuEZmMJQ jpFnkv8vioYuDopKE61DV8oByT/r3jABZCYx9qOL9qTBjh5Fdq/d2X04dY9OE6RoCq neDS7X/OZByM2czMdMljYSEzNV4dCdGGIVn7ZX0A= Received: by mail-wm1-f47.google.com with SMTP id a9so10439620wmm.2 for ; Sun, 20 Sep 2020 12:15:02 -0700 (PDT) X-Gm-Message-State: AOAM532PqpfhrrMvHXGqEGniZGFc7GujMX84J0i7xRPiQPa7mrVZTVzk omsoNhgYKDrU1oOCZSqflYDjJ+yKTi0xCHg5xbgPWg== X-Received: by 2002:a05:600c:2183:: with SMTP id e3mr27891946wme.49.1600629301119; Sun, 20 Sep 2020 12:15:01 -0700 (PDT) MIME-Version: 1.0 References: <20200918124533.3487701-1-hch@lst.de> <20200918124533.3487701-2-hch@lst.de> <20200920151510.GS32101@casper.infradead.org> <20200920180742.GN3421308@ZenIV.linux.org.uk> In-Reply-To: <20200920180742.GN3421308@ZenIV.linux.org.uk> From: Andy Lutomirski Date: Sun, 20 Sep 2020 12:14:49 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/9] kernel: add a PF_FORCE_COMPAT flag To: Al Viro Cc: Matthew Wilcox , Christoph Hellwig , Andrew Morton , Jens Axboe , Arnd Bergmann , David Howells , linux-arm-kernel , X86 ML , LKML , "open list:MIPS" , Parisc List , linuxppc-dev , linux-s390 , sparclinux , linux-block , Linux SCSI List , Linux FS Devel , linux-aio , io-uring@vger.kernel.org, linux-arch , Linux-MM , Network Development , keyrings@vger.kernel.org, LSM List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 20, 2020 at 11:07 AM Al Viro wrote: > > On Sun, Sep 20, 2020 at 04:15:10PM +0100, Matthew Wilcox wrote: > > On Fri, Sep 18, 2020 at 02:45:25PM +0200, Christoph Hellwig wrote: > > > Add a flag to force processing a syscall as a compat syscall. This is > > > required so that in_compat_syscall() works for I/O submitted by io_uring > > > helper threads on behalf of compat syscalls. > > > > Al doesn't like this much, but my suggestion is to introduce two new > > opcodes -- IORING_OP_READV32 and IORING_OP_WRITEV32. The compat code > > can translate IORING_OP_READV to IORING_OP_READV32 and then the core > > code can know what that user pointer is pointing to. > > Let's separate two issues: > 1) compat syscalls want 32bit iovecs. Nothing to do with the > drivers, dealt with just fine. > 2) a few drivers are really fucked in head. They use different > *DATA* layouts for reads/writes, depending upon the calling process. > IOW, if you fork/exec a 32bit binary and your stdin is one of those, > reads from stdin in parent and child will yield different data layouts. > On the same struct file. > That's what Christoph worries about (/dev/sg he'd mentioned is > one of those). > > IMO we should simply have that dozen or so of pathological files > marked with FMODE_SHITTY_ABI; it's not about how they'd been opened - > it describes the userland ABI provided by those. And it's cast in stone. > I wonder if this is really quite cast in stone. We could also have FMODE_SHITTY_COMPAT and set that when a file like this is *opened* in compat mode. Then that particular struct file would be read and written using the compat data format. The change would be user-visible, but the user that would see it would be very strange indeed. I don't have a strong opinion as to whether that is better or worse than denying io_uring access to these things, but at least it moves the special case out of io_uring. --Andy